use ungridded dimensions for stokes drift exchange #1527
Conversation
* removing cmeps restart file from comparison passes cpld control/restart pair to pass * cmeps art will appear as different because field names changes
* all baselines pass if cmeps restart file is removed from comparison list
|
@DeniseWorthen If not necessary to wait for another wave pr, we can start working on this pr. |
|
@jkbk2004 There is a comment on NOAA-EMC/WW3#863 from @MatthewMasarik-NOAA that this PR won't be merged until after Jan 3. |
|
Thanks for the note. We will move to #1529. |
|
@DeniseWorthen I don't plan to merge develop into dev/ufs-weather-model while Jessica is away. I have tested this PR on my end though running the RT suite, and all runs ran fine, with some failing in run_check, though you've noted a baseline change. If you're able to proceed with this PR please go ahead. |
|
@MatthewMasarik-NOAA The baselines will change only because the name of the fields stored in mediator restart files will change. But I'm confused by saying "If you're able to proceed with this PR please go ahead." We need need to be able to merge the component level PRs in order to commit to UWM. So we won't be able to work on the UWM PR until we're sure that WW3 will also be able to be merged. |
|
@DeniseWorthen sure we should probably wait then. |
|
@DeniseWorthen please bring these up to date with respective authoritative repositories
|
1 similar comment
|
@DeniseWorthen please bring these up to date with respective authoritative repositories
|
|
Automated RT Failure Notification |
|
There appears to have been an issue checking out MOM6....it is empty. |
It could be git/orion issue. Let me see if it runs on my account. |
|
Automated RT Failure Notification |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
|
@DeniseWorthen two cases fail on cheyenne.intel: cpld_restart_c192_p8 and hafs_global_multiple_4nests_atm. Path is /glade/scratch/jongkim/rt-1527-intel/jongkim/FV3_RT/rt_43747. |
|
develop branch has no problem for those cases. MPT ERROR: process_vm_readv() had error: 3 |
|
The HAFS case does is standalone and this PR has no impact. I ran both intel and gnu for this pr for testing, so either it is a glitch, or something in the meantime has changed. |
|
I have obtained the same two failures independently. I will need time to debug. The restart c192 case is core-dumping on the FV3/CMEPS PEs. The hafs case for me failed w/ the usual "MPT: shepherd terminated" error. |
|
The c192 tests do not currently use the same TPN=18 setting that the c96 uses (we don't run the bmark on cheyenne). I can get the c192 test to run w/ TPN=18. |
Yeas, both cpld_restart_c192_p8 and hafs_global_multiple_4nests_atm work on cheyenne now with TPN=18. |
|
@BrianCurtis-NOAA Can you please review? |
Yes. One moment. |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Enables the use of ungridded dimensions for the exchange of partitioned stokes drift between MOM6 and WW3.
Issue(s) addressed
Testing
All baselines were run on Cheyenne.intel and Cheyenne.gnu. Since this PR changes the field names within the mediator restart files, the restart file was removed from the file comparison list for all wave-enabled tests. All tests were B4B at 9805fea. New baselines will be required solely because of the field name changes in the mediator restart files.
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies