-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CICE with latest consortium/main #1562
update CICE with latest consortium/main #1562
Conversation
* reverting the bug fix for ktherm=2 allows all cpld tests to pass and the single datm test using ktherm=2 (datm_cdeps_gfs) to also pass all other datm tests which use ktherm=1 fail
We can start testing this PR. I will try from hera. |
Jenkins-ci ORT output |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
Automated RT Failure Notification |
Dogwood (WCOSS2) was having issues on Friday and it's going to be unavailable today. Will need to create baselines after it comes back. |
Description
Updates CICE to the latest Consortium/main.
Includes a bug-fix for ktherm=2 (mushy thermodynamics) with optional new feature to use the actual (prognostic) bulk ice salinity in place of constant (4psu) ice salinity when ktherm=2. This feature is not turned on in this PR. To enable the feature, a new namelist option should be added to the
forcing_nml
in ice_in:saltflux_option = 'prognostic'
This feature should only be used with ktherm=2. Enabling it would change baselines for all ktherm=2 tests.
The
cicedynB
subdirectory has also be renamed tocicedyn
, with associated changes incice_files.cmake
.Top of commit queue on: TBD
Input data additions/changes
Anticipated changes to regression tests:
Changes were tested on cheyenne.intel and cheyenne.gnu with the following results:
-All coupled tests (which all use ktherm=2) and the single NG-GODAS test using ktherm=2 (
datm_cdeps_gfs
) will change answers due to bug-fix. This was verified by running the baselines with the 2-line bug-fix reverted. Baselines using ktherm=2 reproduced in this case except thecpld_control_ciceC_p8
test. The C-grid test changes due to additional bug-fix that is only applicable to C-grid.-All NG-GODAS tests using ktherm=1, with the exception of debug, will change answers due to code refactoring associated with new prognostic salt-flux feature.
Subcomponents involved:
Combined with PR's (If Applicable):
Commit Queue Checklist:
Linked PR's and Issues:
Depends on NOAA-EMC/CICE#56
Closes NOAA-EMC/CICE#55
Testing Day Checklist:
Testing Log (for CM's):