-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster compile and HAFS app to be compiled with 64bit #1578
Faster compile and HAFS app to be compiled with 64bit #1578
Conversation
@SadeghTabas-NOAA Code change looks good to me. Please run RT to check the run time change and if there are any failed test. Thanks |
@SadeghTabas-NOAA please bring these up to date with respective authoritative repositories
|
hera.intel job completed. RT passed, however the runtime increased significantly. |
It looks like, the FASTER compile option makes the runs significantly slower than before. Please find the full RT results for Orion and Hera in the following directory: |
@SadeghTabas-NOAA I was wondering if it slows down across all cases? then, we may need more time for the pr. |
@jkbk2004 I'm doing the RT test for jet and gaea as well, I'll let you know once its done, I'll upload the logs here. |
RT job on jet completed, the FASTER compile option makes the runs significantly slower than before. Please find the full RT results for jet in the following directory: |
Seems that the verdict is we should not use the FASTER option at all? |
@BrianCurtis-NOAA I guess the current version of Faster Compile makes the process much slower and it needs modification or not using it at all. |
I made a google sheet for the Faster Compile option results. It seems Faster Compile made the Compiles process slower, however it increased the speed for the Tests. |
8d97716
to
a863389
Compare
@SadeghTabas-NOAA #1604 was merged. can you sync up? mainly log files. it might be easier way to save your log files and attach in the PR after sync up. |
3ad88b2
to
94cc62a
Compare
e7ccaf2
to
7a2c58e
Compare
@SadeghTabas-NOAA mom6/fv3 restart file format was updated. you can take a look: https://github.com/SadeghTabas-NOAA/ufs-weather-model/blob/FASTER_Compile_Test/tests/tests/control_p8 Another thing to check is this pr adds 4 *_faster test cases and no impact on all other cases. Then, we might combine with #1610. We need to point to @DusanJovic-NOAA hafs_64bit_fms fv3 branch. Sorry I am flipping my mind about combing PRs. If you agree, we can save time in that way. |
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
Automated RT Failure Notification |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
Cheyenne and Gaea sporadically unstable. re-submission of jobs worked out ok for failed cases. |
@BrianCurtis-NOAA @SadeghTabas-NOAA once tests are confirmed on wcoss2, this pr is ready for merging. |
@SadeghTabas-NOAA Could you please edit the title so that we can easily see in the commit list that this also committed the change for HAFs in 64 Bit mode? |
@BrianCurtis-NOAA Thanks, |
@jkbk2004 @SadeghTabas-NOAA All WCOSS2 related testing is completed. Apologies for the delay. |
@SadeghTabas-NOAA fv3 pr was merged. Can you update submodule pointer and revert change in gitmodules? |
@SadeghTabas-NOAA can you make sure about fv3 hash? correct one is NOAA-EMC/fv3atm@8418428 |
…MAQ in rt.conf
Description
This PR contains changes to rt.conf for FASTER compile UFS regression tests.
Changes to rt.conf:
Top of commit queue on: TBD
Input data additions/changes
Anticipated changes to regression tests:
Subcomponents involved:
Combined with PR's (If Applicable):
PR #1610
Commit Queue Checklist:
Linked PR's and Issues:
Testing Day Checklist:
Testing Log (for CM's):