Combo for ccpp/physics #41 and #45 and ccpp/framework submodule pointer update for #462

[grantfirl]

Description

This PR combines 2 ccpp/physics PRs and 1 ccpp/framework PR.

ccpp/physics PR41: changes CMakeLists.txt to depend on the SP library. This is required for JEDI: JCSDA/ufs-bundle#19

ccpp/physics PR45: exposes 3 NSSL MP parameters to the physics namelist

ccpp/framework PR462: addresses an error message bug in the unit conversion part of ccpp_prebuild

No answer changes are expected for any of these changes.

Top of commit queue on: TBD

Input data additions/changes

• No changes are expected to input data.
• There will be new input data.
• Input data will be updated.

Anticipated changes to regression tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

ufs-community/ccpp-physics#53
NOAA-EMC/fv3atm#634

• fixes add three parameters to namelist for NSSL MP ccpp-physics#44
• partially addresses ALGO-61.1: Merge JEDI/UFS branches required for ufs-bundle into authoritative codebase JCSDA/ufs-bundle#19
• fixes Unit converter does not handle a variable with units = 1 NCAR/ccpp-framework#458

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[grantfirl]

Hera/Intel full RT log (SUCCESSFUL):

RegressionTests_hera.intel.log

[zach1221]

Hi, @grantfirl! We're going to begin working to test/review this PR soon, could you sync up your branch, please?

[jkbk2004]

@grantfirl #1547 was merged: ww3 hash update (https://github.com/NOAA-EMC/WW3/tree/af544dca5bf49bf3c3ad8d47b786e8211dcf4bba).

[grantfirl]

@jkbk2004 OK, I'll update the PR branches now. Sorry for the delay.

[jkbk2004]

sure!

[grantfirl]

@zach1221 @jkbk2004 OK, only the ufs-weather-model branch needed to be updated, so everything should be good to test now.

[zach1221]

Please see jenkins-ci ORT logs attached. Everything passed ok.
ufs-weather-model » ort-docker-pipeline » PR-1654 #1 Console [Jenkins].pdf

[grantfirl]

@zach1221 I invited you as a collaborator to my fork of ufs-weather-model. I think that this should do it.

[jkbk2004]

All cases ran ok on orion but rt script exit out w/o cat logs. Manually updated the log for orion.

[jkbk2004]

jet is not stable. no baseline change. so we will skip jet.

[jkbk2004]

cpld_control_p8_faster case on cheyenne. it takes about 1819 to 1879 compile time. But the case itself builds ok if build time is extended.

[zach1221]

@grantfirl We can start the merge process now. Can you please merge your ccpp PR ?

[grantfirl]

@grantfirl We can start the merge process now. Can you please merge your ccpp PR ?

@zach1221 OK, I merged the ccpp PR and updated the fv3atm PR branch in anticipation of merge.

[grantfirl]

I updated .gitmodules and FV3 submodule pointer after fv3atm merge. This is ready for final review/merge.

[zach1221]

@SadeghTabas-NOAA would you be able to provide approval once more? You previous one was dismissed after the commit.