Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize custom restart names for WW3 #1684

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Mar 28, 2023

Description

Utilizes configuration variable user_sets_restname in nems.configure to trigger a custom restart file name in WW3. Restarts will be produced with name ufs.APP.ww3.r.YYYY-MM-DD-SSSSS where APP is either cpld or hafs.

If a file of the expected name is not present at restart, WW3 will abort with error

 EXTCDE MSG=required initial/restart file ufs.cpld.ww3.r.2021-03-22-64800 does not exist

On a restart run, the following will be written to stdout

WW3: reading initial/restart file ufs.cpld.ww3.r.2021-03-22-64800

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

The hafs_regional_atm_ocn_wav and hafs_regional_atm_wav will fail because the name of the restart file changes. Manual comparison against the existing baseline file shows they are B4B. All other tests pass.

During testing, the hera.intel log was not produced but the rt_ logs were catted manually. The cpld_control_p8 test timed-out for GNU.

intel.log
RegressionTests_cheyenne.gnu.log

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

* set configuration variable true to use non-default restart file
names in WW3
* change name of WW3 used for restart tests
* change name of WW3 in hafs wav tests
@@ -74,6 +74,7 @@ WAV_attributes::
logfile = wav.log
mesh_wav = @[MESH_WAV]
multigrid = @[MULTIGRID]
user_sets_restname = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeniseWorthen It's the goal from the WW3 side for the restart names to be controlled by a WW3 input file instead of a "nems.configure" restart file. Just wanted to make you aware that is a planned change from the WW3 side in the near future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to know the goal on WW3 side. I think we can get this change in at this time. We can review it when the ww3 restart filename changes are ready. the purpose here is to have consistent restart file names as much as possible for all the model components. Thanks.

@DeniseWorthen DeniseWorthen added the Baseline Updates Current baselines will be updated. label Mar 29, 2023
jkbk2004 pushed a commit that referenced this pull request Apr 3, 2023
…pplication; utilize custom restart names for WW3 (was #1684)  (#1692)

* set configuration variable true to use non-default restart file
names in WW3
* change name of WW3 used for restart tests
* change name of WW3 in hafs wav tests

* update CMEPS
@DeniseWorthen
Copy link
Collaborator Author

Merged in PR #1692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For a "continue" run, WW3 should not start unless a restart is present
3 participants