-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated FV3 with RRTMGP improvements. #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the regression test files - almost there!
@@ -0,0 +1,85 @@ | |||
############################################################################### | |||
# | |||
# FV3 CCPP GFS v15.2 w/ RRTMGP compiled with 32-bit dynamics test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is really picky, but the dynamics are not compiled in 32bit for your tests (see COMPILE lines in rt.conf
, they don't have 32BIT=Y
). Best to simply remove "compiled with 32-bit dynamics"
# | ||
############################################################################### | ||
|
||
export TEST_DESCR="Compare FV3 32bit CCPP GFS v15.2 w/ RRTMGP results with previous trunk version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, simply remove "32bit"
@@ -0,0 +1,85 @@ | |||
############################################################################### | |||
# | |||
# FV3 CCPP GFS v15.2 w/ RRTMGP compiled with 32-bit dynamics test in DEBUG mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
# | ||
############################################################################### | ||
|
||
export TEST_DESCR="Run FV3 32bit CCPP GFS v15.2 w/ RRTMGP in DEBUG mode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
@@ -0,0 +1,85 @@ | |||
############################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this file should be tests/tests/fv3_ccpp_gfs_v15p2_RRTMGP_debug
and not tests/tests/fv3_ccpp_gfs_v15p2_debug_RRTMGP
?
# | ||
############################################################################### | ||
|
||
export TEST_DESCR="Compare FV3 32bit CCPP GFS v16beta w/ RRTMGP results with previous trunk version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
32bit
@@ -0,0 +1,85 @@ | |||
############################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this file should be tests/tests/fv3_ccpp_gfs_v16beta_RRTMGP_debug
and not tests/tests/fv3_ccpp_gfs_v16beta_debug_RRTMGP
?
@@ -0,0 +1,85 @@ | |||
############################################################################### | |||
# | |||
# FV3 CCPP GFS v16beta w/ RRTMGP compiled with 32-bit dynamics test in DEBUG mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
32bit
# | ||
############################################################################### | ||
|
||
export TEST_DESCR="Run FV3 32bit CCPP GFS v16beta w/ RRTMGP in DEBUG mode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
32bit
|
||
export TEST_DESCR="Run FV3 32bit CCPP GFS v16beta w/ RRTMGP in DEBUG mode" | ||
|
||
export CNTL_DIR=fv3_gfs_v16beta_debug_RRTMGP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_debug
comes last
# | ||
############################################################################### | ||
|
||
export TEST_DESCR="Run FV3 32bit CCPP GFS v16beta w/ RRTMGP in DEBUG mode" | ||
export TEST_DESCR="Run FV3 CCPP GFS v16beta w/ RRTMGP in DEBUG mode" | ||
|
||
export CNTL_DIR=fv3_gfs_v16beta_debug_RRTMGP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last ones: change export CNTL_DIR=fv3_gfs_v16beta_debug_RRTMGP
to export CNTL_DIR=fv3_gfs_v16beta_RRTMGP_debug
(and similar for GFS v15p2 debug) so that the run directories are consistent with the test names, please - avoids confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks for accommodating all my requests for changes. I'll get started with testing this, approval will follow after the current commit is in and this PR is updated.
I checked out the code using
On hera.intel, I get failures for the following regression tests:
I checked two of them, both fail for the same reason (this is from the
Note: when I grep for failed tests using
I get more failures:
@DusanJovic-NOAA @junwang-noaa Important. Using
but:
|
Here is the error with traceback:
and the offendling line 3449 from
Thus, something in the
|
I removed all the old RRTMGP stuff from |
@climbfuji |
I got the above tests fixed. The major problem of rt.sh not reporting failures correctly still exists, however. @DusanJovic-NOAA @junwang-noaa Please have a look at I assume the reason they fail is because the failure occurs in the
Of course, @dustinswales needs to fix the actual error by creating |
…move old tests; remove old RRTMGP namelist settings from parm/ccpp_control.nml.IN
…/ccpp_v16beta_c96_rrtmgp.nml.IN
Updates for ufs-weaather-model #178 (Updated FV3 with RRTMGP improvements) 2020/08/05
Update ufs-weather-model for Dustin's PR
@climbfuji |
Now it looks like everything is up to date. I think we should get started by running the tests on hera.intel and hera.gnu against the existing baseline (to make sure all non-RRTMGP tests still pass). Should I do that? |
Yes |
They are running now on hera for intel and gnu. |
Regression testing on hera.intel and hera.gnu against existing baselines. All non-RRTMGP tests pass, all RRTMGP tests fail because of missing baselines (but they all run to completion). rt_hera_gnu.log Creating new baselines now on hera.gnu, hera.intel, orion.intel. |
Created new baselines on orion.intel, hera.intel, hera.gnu; all tests passed. rt_orion_intel_create.log |
Update regression test date tag
Regression tests passed on all tier-1 platforms. Sent a PR to @dustinswales to update his branch used for this PR: https://github.com/dustinswales/ufs-weather-model/pull/6 |
Jun,
I am not sure if it is appropriate for me to review this code. I know
nothing about rrtmgp.
Moorthi
…On Fri, Aug 7, 2020 at 9:59 AM Jun Wang ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa> requested your review on:
#178 <#178>
Updated FV3 with RRTMGP improvements..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#178 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYRWK5P2E2WMYI2373LR7QCE3ANCNFSM4PMAHI3A>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: Shrinivas.Moorthi@noaa.gov
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Regression test logs for tier-1 platforms
…ry update in dycore (ufs-community#178) * contributions from @SMoorthi-emc to fix the global restart reproducibility and to keep compiling without CCPP * updates the submodule pointers for GFDL_atmos_cubed_sphere and ccpp-physics * bugfix in ccpp/CMakeLists.txt to correctly set AVX2 flags or not (discovered by Yunheng) * changes mod_name of non-phys tendencies in GFS_diagnostics.F90 to gfs_dyn from gfs_phys (from @grantfirl)
Description
Included in this PR is the added functionality to use the GFS suite definition files (SDFs) with the RRTMGP radiation scheme. v15p2 and v16beta.
Additional changes are described in the ccpp-physics PR (link below)
Issue(s) addressed
N/A
Testing
Regression tests passed on Hera using Intel.
Dependencies