-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rt.sh to allow creating new baselines only for a subset of tests #1834
Update rt.sh to allow creating new baselines only for a subset of tests #1834
Conversation
I would normally just cp rt.conf to rt.test and edit rt.test and run with -l. How does this improve on that? |
If you use '-l rt.test' in create mode (-c) you can not run full test afterwards verifying that all tests pass, some using new baselines, some using current baselines. |
I wonder if you could write something that upon baseline creation failure for a full rt suite, a file could be generated with the list of baseline generating tests that failed, making it easy to re-run the failed tests? |
I think this sentence: This allows developers to create new baselines only for the tests they expect to change the baselines while using current baselines for tests they expect to not change the outputs. describes that situation. How developers come up with the list of tests that need new baselines is up to them. Either by running full set of tests and finding which one failed or by reasoning based on the changes they made. |
Changes combined into #1467 . Closing |
Description
A new option has been added to rt.sh script. If option -b <file> is passed to rt.sh together with -c (create new baselines) then the script will run only tests specified in <file> (one test name per line) and create new baselines which will be saved in ${NEW_BASELINE} directory. For all other tests specified rt.conf current baseline directory will be linked to ${NEW_BASELINE}.
This allows developers to create new baselines only for the tests they expect to change the baselines while using current baselines for tests they expect to not change the outputs.
For example:
If file named 'new_baselines' contain:
then, running:
./rt.sh -e -c -b new_baselines
wil create new baselines only for these two tests and put them in ${NEW_BASELINE}, while symlinks will be created for all other tests.
Finally, running:
./rt.sh -e -m
will run a full test in verify mode against new baselines, which will confirm that no other tests other than those listed above change the outputs.
Input data additions/changes
Anticipated changes to regression tests:
Subcomponents involved:
Library Updates/Changes
Combined with PR's (If Applicable):
Commit Queue Checklist:
Linked PR's and Issues:
Testing Day Checklist:
Testing Log (for CM's):