Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify BUILD_DIR when using compile.sh #1838

Closed

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jul 16, 2023

Description

The GFS and GEFS applications call compile.sh to build the ufs-weather-model.
As it stands currently, the ufs-weather-model build directory ends up in the source tree of the GFS and GEFS.
The GFS and GEFS are collecting all the build directories of the components in a single location for the applications.

This PR:

  • allows a user (or application) to specify a BUILD_DIR before invoking compile.sh. This allows the build directory to be out of the source directory.
  • does not alter the default behavior of the script compile.sh.

Input data additions/changes

  • No changes are expected to input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.

Subcomponents involved:

  • none

Library Updates/Changes

  • Not Needed

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

None

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA A quick sanity check on orion/hera works perfectly fine for this BUILD_DIR fix. We can apply this fix to the next PR once you approve.

@zach1221
Copy link
Collaborator

Hi, @aerorahul . Wanted to make you aware that once #1815 is synced and conflicts resolved, we're planning to add your code changes in this PR to that one. We'll ensure you're credited as well. Please let me know if you have any questions regarding this.

@kbooker79 kbooker79 added noaacloud-aws-RT Run regression tests in NOAAcloud (AWS) and removed noaacloud-aws-RT Run regression tests in NOAAcloud (AWS) labels Jul 21, 2023
@github-actions
Copy link

@aerorahul please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

@aerorahul
Copy link
Contributor Author

@aerorahul please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

done.

@zach1221
Copy link
Collaborator

#1815 has been merged into ufs-community:develop, with the one code change from this PR. Unless you have any objections, I will close this PR. @aerorahul

@zach1221 zach1221 closed this Jul 24, 2023
@aerorahul aerorahul deleted the feature/builddir-opt branch February 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants