Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to smc pert and fix bug in stc pert #2043

Closed
wants to merge 2 commits into from
Closed

Add comments to smc pert and fix bug in stc pert #2043

wants to merge 2 commits into from

Conversation

yuanxue2870
Copy link

@yuanxue2870 yuanxue2870 commented Dec 15, 2023 •
edited by BrianCurtis-NOAA
Loading

PR Author Checklist:

  • [x ] I have linked PR's from all sub-components involved in section below.
  • [x ] I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Hercules AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • [x ] I have filled out all sections of the template.

Description

Commit Message

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

NOAA-PSL/stochastic_physics/pull/70

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • [x ] stochastic_physics
  • none

Anticipated Changes

Input data

  • [x ] No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • [x ] No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • [x ] Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Dec 18, 2023
Merged
@SamuelTrahanNOAA
Copy link
Collaborator

@jkbk2004 wants me to combine this with #2040 and #2041, but the submodule hash doesn't match the NOAA-PSL/stochastic_physics#70 PR.

@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Dec 18, 2023
Merged
35 tasks
@BrianCurtis-NOAA BrianCurtis-NOAA mentioned this pull request Dec 19, 2023
Closed
41 tasks
zach1221 pushed a commit that referenced this pull request Dec 19, 2023
@SamuelTrahanNOAA
bug fix: disable concurrency in GFS_phys_time_vary_init NetCDF calls…
1d90c04 
… AND #2040 and #2043 (#2041)

General clean-up, and CCPP concurrency bug fixes

1. Remove nfhout, nfhmax_hf, nfhout_hf and nsout from fv3atm and the regression tests. ( Remove nfhout, nfhmax_hf,  nfhout_hf etc configuration parameters NOAA-EMC/fv3atm#731 )
2. Add comments to smc pert and fix bug in stc pert ( Fix bugs in soil temperature perturbation #2042 )
3. Disable concurrency in NetCDF calls within CCPP GFS_phys_time_vary_init subroutine to avoid crashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bugs in soil temperature perturbation
2 participants
@yuanxue2870 @SamuelTrahanNOAA