Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] "to use fms/2024.1 & RUC LSM deep soil temperature updates" #2343

Conversation

haiqinli
Copy link
Contributor

@haiqinli haiqinli commented Jun 26, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Commit Message:

* UFSWM -  
  * FV3 - 
    * ccpp-physics - 

### Priority:
<!--
Please provide the priority you would prefer this pull request to have.
* High: Time-sensitive project.
Please delete the ones that are not applicable
-->
* High: for the RRFS.v1

## Git Tracking

### Sub component Pull Requests:
<!--
Please provide a list of sub-components involved with this pull request.
Please provide links to the sub-component pull requests as shown below.
Please delete what is not needed.

-->
* FV3: https://github.com/NOAA-EMC/fv3atm/pull/852
  * ccpp-physics: https://github.com/ufs-community/ccpp-physics/pull/217
 
### UFSWM Blocking Dependencies:
* None

---
## Changes
### Regression Test Changes (Please commit test_changes.list):
<!--
Please let us know if this PR creates new baselines, changes baselines or not.
* PR Updates/Changes Baselines.
-->

### Input data Changes:
<!--
If there are any changes to input-data for a test, please provide information here.
Please delete what is not needed.
-->
* None.

### Library Changes/Upgrades:
<!-- Library updates take time. Please provide library and version information here.
** SPECIAL INSTRUCTIONS **
If this PR needs updates to libraries please make sure to accomplish the following tasks:
- Create separate issue in (https://github.com/JCSDA/spack-stack) asking for update to library. Include library name, library version.
- Add issue link from JCSDA/spack-stack following this item <!-- for example: "* JCSDA/spack-stack#1757"

Please delete what is not needed.
-->
* No Updates
  
---
<!-- STOP!!! THE FOLLOWING IS FOR CODE MANAGERS ONLY. PLEASE DO NOT FILL OUT -->
## Testing Log:
- RDHPCS
  - [*] Hera
  - [ ] Orion
  - [ ] Hercules
  - [ ] Jet
  - [ ] Gaea
  - [*] Derecho
- WCOSS2
  - [*] Dogwood/Cactus
  - [ ] Acorn
- [ ] CI
- [ ] opnReqTest (complete task if unnecessary)

@MatthewPyle-NOAA
Copy link
Collaborator

@haiqinli @jkbk2004 Starting to work on this one on WCOSS - creating new baselines.

@jkbk2004
Copy link
Collaborator

@MatthewPyle-NOAA I am catching up on RDHPCS side.

@jkbk2004
Copy link
Collaborator

@MatthewPyle-NOAA there is hercules file system issue. I am trying to see if I can use Derecho for additional test.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jul 3, 2024

@MatthewPyle-NOAA sorry for delay. I pushed Derecho test log ok. I will double to check if I can recover hercules baseline later. I think we can start merging process. I will go to sub PRs.

@MatthewPyle-NOAA
Copy link
Collaborator

Thanks for the update, @jkbk2004

@jkbk2004 jkbk2004 requested a review from MatthewPyle-NOAA July 3, 2024 17:38
Copy link
Collaborator

@jkbk2004 jkbk2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthewPyle-NOAA this pr can be merged with commit message.

* to compile the model with new fms/2024.01

* Update the RUC LSM deep soil temperature from climatology to real forecast.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jul 3, 2024

@MatthewPyle-NOAA Just to remind to clean up unnecessary commit messages when squash merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants