-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dumpfields=true option by using ESMF_FieldBundleWrite #2355
Fix dumpfields=true option by using ESMF_FieldBundleWrite #2355
Conversation
"Pull Request Tests / Check if repos are up to date (pull_request)" failed with this error:
This check should be either fixed or disabled, This test error is misleading. |
Regression test passed on Hera: |
Regression test passed on WCOSS2: |
@DusanJovic-NOAA we're ready to move to this PR. Can you please sync up your branch? |
#2352 was merged in, please resync and resolve conflicts so we can get started with testing this PR, thank you. |
Done. |
@BrianCurtis-NOAA FYI for testing |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to commit test_changes.list to confirm there is no change in the baseline?
Done. 4124fe8 |
Ok, we should be all set to start the merge process, I'll let the FV3 sub PR know. |
FV3 was merged in, @DusanJovic-NOAA please go ahead and sync/revert .gitmodules |
Commit Queue Requirements:
Description:
This PR fixes
dumpfields=true
option in FV3 which can be used to write all coupling fields (from import and export states) by using updated version of ESMF'sESMF_FieldBundleWrite
function instead of oldESMFIO_Write
.Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: