Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dumpfields=true option by using ESMF_FieldBundleWrite #2355

Merged
merged 26 commits into from
Jul 30, 2024

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Jul 3, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR fixes dumpfields=true option in FV3 which can be used to write all coupling fields (from import and export states) by using updated version of ESMF's ESMF_FieldBundleWrite function instead of old ESMFIO_Write.

Commit Message:

* UFSWM - Fix dumpfields=true option in FV3 by using ESMF_FieldBundleWrite
  * FV3 - Fix dumpfields=true option by using ESMF_FieldBundleWrite

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as draft July 3, 2024 13:46
@DusanJovic-NOAA DusanJovic-NOAA self-assigned this Jul 3, 2024
@DusanJovic-NOAA DusanJovic-NOAA added the No Baseline Change No Baseline Change label Jul 3, 2024
@DusanJovic-NOAA
Copy link
Collaborator Author

"Pull Request Tests / Check if repos are up to date (pull_request)" failed with this error:

Run helper_id=$(cat ~/id_file)
cat: /home/runner/id_file: No such file or directory
Error: Process completed with exit code 1.

This check should be either fixed or disabled, This test error is misleading.

@DusanJovic-NOAA
Copy link
Collaborator Author

Regression test passed on Hera:
RegressionTests_hera.log

@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as ready for review July 8, 2024 13:03
@DusanJovic-NOAA
Copy link
Collaborator Author

Regression test passed on WCOSS2:
RegressionTests_wcoss2.log

@zach1221
Copy link
Collaborator

@DusanJovic-NOAA we're ready to move to this PR. Can you please sync up your branch?

@FernandoAndrade-NOAA
Copy link
Collaborator

#2352 was merged in, please resync and resolve conflicts so we can get started with testing this PR, thank you.

@DusanJovic-NOAA
Copy link
Collaborator Author

#2352 was merged in, please resync and resolve conflicts so we can get started with testing this PR, thank you.

Done.

@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Jul 26, 2024
@FernandoAndrade-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA FYI for testing

Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to commit test_changes.list to confirm there is no change in the baseline?

@DusanJovic-NOAA
Copy link
Collaborator Author

Do you want to commit test_changes.list to confirm there is no change in the baseline?

Done. 4124fe8

junwang-noaa
junwang-noaa previously approved these changes Jul 29, 2024
@FernandoAndrade-NOAA
Copy link
Collaborator

Ok, we should be all set to start the merge process, I'll let the FV3 sub PR know.

@FernandoAndrade-NOAA
Copy link
Collaborator

FV3 was merged in, @DusanJovic-NOAA please go ahead and sync/revert .gitmodules

@jkbk2004 jkbk2004 merged commit b5a1976 into ufs-community:develop Jul 30, 2024
3 checks passed
@DusanJovic-NOAA DusanJovic-NOAA deleted the dump_cpl_fields branch July 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
7 participants