Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hpc-stack for Actions CI #299

Closed
wants to merge 7 commits into from

Conversation

MinsukJi-NOAA
Copy link
Contributor

Description

Use hpc-stack (with upp support) in docker container used by CI.
Minor change in rt_utils.sh to fail regression test if comp_ncfile.py fails to load required modules.

Issue(s) addressed

Resolves #240 #277 #296

Testing

GitHub Actions tested for working properly: https://github.com/MinsukJi-NOAA/ufs-weather-model/actions/runs/379981603

@climbfuji
Copy link
Collaborator

@junwang-noaa @DusanJovic-NOAA @MinsukJi-NOAA We originally planned to include this in my PRs (#297 & Co). I though this would only be touching ci files, but given the change in rt_utils.sh I am reluctant to pull this into my PR. I already completed the regression testing on hera.intel, hera.gnu, orion.intel, and I am close to completing gaea.intel, too. Thoughts?

@junwang-noaa
Copy link
Collaborator

@climbfuji If possible, I do hope to get this fix in as soon as possible. Can we help on rerunning RT on hera/orion?

@MinsukJi-NOAA
Copy link
Contributor Author

@climbfuji , Better solution is in the pipe to address #296. I will revert back the rt_utils.sh change for now.

@climbfuji
Copy link
Collaborator

@junwang-noaa wants to include the change. I'll pull your PR in and rerun on hera.intel, hera.gnu, orion.intel, gaea.intel.

@climbfuji
Copy link
Collaborator

Please convert your PR into "ready for review", I'll mention it in my PR. Thanks!

@junwang-noaa
Copy link
Collaborator

Minsuk, I found a bug in compile.sh:

mv ${BUILD_DIR}/ufs_model ${PATHTR}/tests/${BUILD_NAME}.exe
cp ${PATHTR}/modulefiles/${MACHINE_ID}/fv3 ${PATHTR}/tests/modules.${BUILD_NAME}

should be:
mv ${BUILD_DIR}/ufs_model ${PATHTR}/tests/${BUILD_NAME}.exe
if [[ "${MAKE_OPT}" == "DEBUG=Y" ]]; then
cp ${PATHTR}/modulefiles/${MACHINE_ID}/fv3_debug ${PATHTR}/tests/modules.${BUILD_NAME}
else
cp ${PATHTR}/modulefiles/${MACHINE_ID}/fv3 ${PATHTR}/tests/modules.${BUILD_NAME}
fi

Would you mind adding it in your PR? Thanks.

DusanJovic-NOAA pushed a commit that referenced this pull request Nov 25, 2020
…, updates to other GSL physics (#297)

- add unified gravity wave drag (called unified ugwp) that combines the UGWP v1 with the GSL drag suite
- replace high-resolution SAR (standalone regional) regression test with 25km SAR regression test
- update submodule pointer for fv3atm for the changes described in the associated PRs listed below
- add `rt_ccpp_dev.conf` that contains the developmental CCPP tests used by GSL and DTC (so that folks are aware of what is tested and how by DTC and GSL, in addition to what is in `rt.conf` and `rt_gnu.conf`)
- turn on calls to `gcycle`/`sfcsub` for RUC LSM
- regression test configuration scripts for MYNN surface layer
- add `fv3_debug` modules for cheyenne.intel and cheyenne.gnu (per request from @DeniseWorthen)
- bugfix in `rt.sh` to copy two missing input directories `fv3_regional_quilt_netcdf_parallel` and `fv3_stretched_nest_debug` when creating new baselines using `rt.sh -c`
- enable regression testing on Gaea with Intel using the current hpc-stack-nco installation, can now use ecflow
- update of CI tests and small bugfix when comparing results using `tests/compare_ncfile.py` from @MinsukJi-NOAA (see #299 for details) - note, the update to `tests/compare_ncfile.py` had to be reverted

Co-authored-by: DomHeinzeller <58610420+DomHeinzeller@users.noreply.github.com>
Co-authored-by: samuel.trahan <Samuel.Trahan@noaa.gov>
Co-authored-by: hannah barnes <hannah.barnes@noaa.gov>
Co-authored-by: Michael Toy <michael.toy@noaa.gov>
Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>
@climbfuji
Copy link
Collaborator

Note. This PR was pulled into #297. However, the change in rt_utils.sh to fix a problem with silently failing regression tests if comp_ncfile.py fails to load required modules (commit 2eaea2e) had to be reverted manually.

I suggest closing this PR and issues #240 and #277, but keep issue #296 open.

@MinsukJi-NOAA
Copy link
Contributor Author

Note. This PR was pulled into #297. However, the change in rt_utils.sh to fix a problem with silently failing regression tests if comp_ncfile.py fails to load required modules (commit 2eaea2e) had to be reverted manually.

I suggest closing this PR and issues #240 and #277, but keep issue #296 open.

I agree.

@MinsukJi-NOAA MinsukJi-NOAA deleted the ci-update branch December 2, 2020 23:43
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Add custom post config file capability

* Switch custom UPP config file check to setup.sh

* Additional mods needed for custom UPP functionality

* Add print statementsfor flat file location

* Add print statementsfor flat file location

* Revert "Add print statementsfor flat file location"

This reverts commit c1cb2a61f1a00f440f11bc042c3accdcbe8950c5.

Co-authored-by: Tracy <tracy.hertneky@noaa.gov>
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
## DESCRIPTION OF CHANGES: 
Minor edits to documentation of python graphics scripts.

## TESTS CONDUCTED: 
None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use hpc-stack container for CI test
3 participants