Remove IPD (step 1) #331

climbfuji · 2020-12-15T16:35:59Z

Description

Make CCPP=Y the default in tests/compile.sh. Remove CCPP=Y from tests/rt*.conf and adjust formatting.

Also:

update submodule pointer for MOM6 to include PR update MOM6 to GFDL's 20201218 commit #341 ("Update MOM6 to GFDL's 20201218 commit")
add modulefiles/wcoss_cray/fv3_debug (identical to modulefiles/wcoss_cray/fv3)
fix broken utest (see utest broken with WW3 update #348)

Issue(s) addressed

This is step 1 of NOAA-EMC/fv3atm#214 - minimal changes only, as previously agreed upon.

Fixes #348

Testing

Regression/manual testing will be done on all tier-1,2,3 platforms (tier-1 pre-commit, tier-2,3 as time permits).

Preliminary regression testing on hera 12/15/2020:

all tests pass with hera.gnu against existing baseline (develop-20201215)
rt_hera_gnu.log
all tests pass with hera.gnu against existing baseline (develop-20201215)
rt_hera_intel.log

This preliminary regression testing will be repeated once it is time to commit these PRs, before removing the _ccpp or _prod suffices from the regression test baseline/run directories (this will require creating new baselines).

Dependencies

NOAA-EMC/GFDL_atmos_cubed_sphere#48
NOAA-EMC/fv3atm#215
#331

…nd testing

…/rt*conf and adjust formatting

… it is the first argument

…r-model into remove_ipd

DusanJovic-NOAA · 2020-12-16T14:32:46Z

tests/rt.sh

      if [[ ${MAKE_OPT^^} =~ "REPRO=Y" ]]; then
        RT_SUFFIX="_repro"
        BL_SUFFIX="_repro"
-      elif [[ ${MAKE_OPT^^} =~ "CCPP=Y" ]]; then
+      else
        RT_SUFFIX="_prod"
        BL_SUFFIX="_ccpp"


Can BL_SUFFIX be removed?

I was thinking to do this, yes, if @junwang-noaa and you are ok. I made the change and will keep it until the last minute (before creating new baselines), however, so that I can test against the existing baselines first when it is time to commit. This way we know for sure that the PR doesn't change anything we don't expect it to change.

I think it is good to remove all the ccpp in the test name including both prod and repro

As I said, this will require several changes in fv3_conf/* files and I would really prefer to do this separately. It's ok to remove the _ccpp and _prod suffices as suggested by Dusan, because that is a change in this file only, but renaming all tests is too much for this commit in my opinion.

If you want to have incremental commits, that is fine, please specify that in your PR. maybe we can call this IPD removal Part1.

Sure, I updated the issue and the two PRs.

Also if part 2 is renaming the test. Maybe we also need to have part3 to remove the "ifdef CCPP" in fv3 code and remove the -DCCPP=ON? So far from here it is not clear to me what the "Remove IPD" means

Please read the issue.

The removal will be part of one of the next steps when we rename all regression tests etc.

junwang-noaa · 2020-12-16T15:45:59Z

tests/rt.conf

-RUN     | fv3_ccpp_ca                                                                                                                    | standard    | orion.intel    | fv3         |
-RUN     | fv3_ccpp_ca                                                                                                                    | standard    | cheyenne.intel | fv3         |
-RUN     | fv3_ccpp_lndp                                                                                                                  | standard    | hera.intel     | fv3         |
+RUN     | fv3_ccpp_control                                                                                                        | standard    |                | fv3         |


I'd suggest to remove all the ccpp in the test names

Can do, but this means several changes in fv3_conf files, too (linking restart files from a previous coldstart run etc).

Originally we wanted to make this commit as small as possible and it is growing and growing. There is a lot more cleanup work to be done (see also the different steps identified in my issue). I suggest to add this as another cleanup step to the issue instead of commingling everything in one commit.

tests/compile.sh

…r-model into remove_ipd

junwang-noaa · 2020-12-20T00:14:14Z

@climbfuji, Jiande updated MOM6 (see issue #341, would you mind updating the MOM6 to point to the latest dev/emc version in this PR? The update will not change results. Thanks

…r-model into remove_ipd

…; skip-ci

climbfuji · 2020-12-28T15:28:30Z

@climbfuji, Jiande updated MOM6 (see issue #341, would you mind updating the MOM6 to point to the latest dev/emc version in this PR? The update will not change results. Thanks

I updated the MOM6 submodule pointer. Now waiting for the current commit (WW3 update) to be merged before pulling that one in and running the regression tests.

…r-model into remove_ipd

climbfuji · 2020-12-28T18:39:31Z

This PR is ready for testing.

climbfuji · 2020-12-28T18:47:40Z

@MinsukJi-NOAA same for this PR, the utests fail with a non-informative error message:

107 cases to compile: std
108 compiling std with compile option CCPP=Y SUITES=FV3_GFS_2017
109 Died with error code 2
110 The command '/bin/sh -c ./utest -n $test_name -c $build_case -z' returned a non-zero code: 2
111
112 Error: Process completed with exit code 2.

Could you take a look, please? Thanks.

climbfuji · 2020-12-28T23:59:59Z

The CI tests now pass, I am capturing a screenshot so that we can skip rerunning them if necessaary.

…ra.gnu, hera.intel, orion.intel, wcoss_dell_p3; skip-ci

…onal_quilt_netcdf_parallel (timeout on jet); skip-ci

climbfuji · 2020-12-29T14:33:41Z

@DusanJovic-NOAA Ready to merge. Jun is on leave today, as far as I know. The CI tests did pass yesterday, up to you to wait for them to complete (and to see if Jun is approving the PR or not).

@SMoorthi-emc

* Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Feature/update mom6 and retain b4b results for 025x025 resolution (ufs-community#290) * point MOM6 to new branch which corresponding to GFDL 20201022 commit * modify fms_files.cmake and mom6_files.cmake to reflect changes in MOM6 code as this version of MOM6 contains some file deletion, new files being added and renaming of files * manually set MOM6 parameters in order to retain origonal results for 0.25x0.25 resolution * update MOM6 to include Bugfix for mom6solo to be built * modify compile.sh to allow mom6solo compiling * modify MOM_input_template for all resolutions based on GFDL MOM6-example main branch update on 20201022 * change executable permissions for CMakeLists.txt * chmod 644 to 6 files Dom pointed out * chmod for CMakeLists.txt and tests/compile.sh * change baseline directpory to 20201202 in rt.sh * Update CICE, Move regression test input outside baseline directory (ufs-community#270) *Updates CICE to most recent develop branch of NOAA-EMC * Sets n_aero (number of aerosols) in ice_in_template to 0. * removes trailing whitespace from ice_in * moves regression test input outside baseline directory (ufs-weather PR ufs-community#312) Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> * Updates to build for JEDI linking/control, add wcoss2 (ufs-community#295) * Build on wcoss2 (acorn) * Use -march=core-avx2 instead of -xCORE-AVX2 on wcoss2 * Updates to build for JEDI linking/control * Removed unnecessary include files and INLINE POST setting * Updated to address PR suggestions. * Add rt_acorn.conf. Change /lfs/h2 to /lfs/h1. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * regression test results * Updated .gitmodules and removed extraneous file * Fixed .gitmodules and updated pointer for FV3 * Updated pointer to NEMS repo Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Final-final GFS v16 updates / restart reproducibility bugfixes (ufs-community#325) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Add GFS v16 beta restart test, update stochastics test * Update regression test baseline date tag to 20201214; skip-ci * tests/rt.conf: bugfix, add missing 'fv3' to new stochy tests; skip-ci * Regression test logs for gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Run GFS v16beta tests also on wcoss; regression test logs for wcoss; skip-ci * Regression test logs for cheyenne.intel and cheyenne.gnu * Revert change to .gitmodules and update submodule pointer for fv3atm * Add optional bulk flux calculation in ufs-datm (ufs-community#266) * Update NEMS DATM and CMEPS to allow the optional bulk flux formulation; add two tests using the option * Update top level CMakeList.txt to have compile flags for MOM6 and CICE6 identical for ufs-cpld and ufs-datm * Add optional configuration variable to nems.configure to specify the directory where CMEPS will write restarts * Adds cheyenne tasking variables to default_vars and sets WW3_COMP to cheyenne for platform cheyenne.intel *NOTE: Baselines develop-20201215 exist on all platforms, regression tests were run against exactly that baseline on all systems except cheyenne.intel. On cheyenne.intel the tests were run against 20201214, and this baseline is identical to 20201215 (as per "diff -r develop-20201214 develop-20201215"). Co-authors: @DusanJovic-NOAA @aerorahul @JessicaMeixner-NOAA skip-ci * Add 2 new tests for DATM-MOM6-CICE6 application (ufs-community#332) * Add the following 2 tests: datm_restart_cfsr, datm_debug_cfsr * Add wcoss_dell_p3.log. * Add Hera log, Orion log, wcoss_dell_p3 log. * RRTMGP and Thompson MP coupling (ufs-community#323) * Feature branch with RRTMGP and Thompson MP * Updated FV3/ccpp-physics. Added namelist and configuration for RRTMGP RTs using GSD physics. * Updated FV3 * Update physics in FV3 * Updated baselines in rt.sh * Updated RT logs. Updated FV3 physics submodule pointer. * Updated FV3 hash and .gitmodules * Regression test log for PR ufs-community#323 for jet.intel (ufs-community#336) * Update modules with hpc-stack v1.1.0 (ufs-community#319) * Update modules with hpc-stack v1.1.0 * Minor bug fixes to CCPP UGWP Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Replace old regional SDF with FV3_GFS_v15_thompson_mynn (ufs-community#333) * Replace old FV3_GFS_2017_gfdlmp_regional SDF for regional tests with FV3_GFS_v15_thompson_mynn. * Final path to IC's and new results. Also, input.nml updated. * Update RegressionTests_wcoss_dell_p3.log * Update RegressionTests_wcoss_cray.log * Update RegressionTests_hera.intel.log * Update RegressionTests_jet.intel.log * Update RegressionTests_orion.intel.log * Update RegressionTests_cheyenne* logs. * Update RegressionTests_hera.gnu.log * Feature/ww3update (ufs-community#334) This updates the WW3 submodule pointer to point to the top of the WW3 develop branch. The path to WW3 inputs is changed to input-data-20201201/WW3_input_data_20201207/ * Remove IPD (step 1) (ufs-community#331) Make CCPP=Y the default in tests/compile.sh. Remove CCPP=Y from tests/rt*.conf and adjust formatting. Update submodule pointer for MOM6 to include PR ufs-community#341 ("Update MOM6 to GFDL's 20201218 commit") Add modulefiles/wcoss_cray/fv3_debug (identical to modulefiles/wcoss_cray/fv3) Fix broken utest (see ufs-community#348) * Update the format of rt.conf (ufs-community#349) Update the format of MACHINES column in rt.conf (and other .conf files). This column can be either empty, which means a test will run on all supported machines, or start with - or + sign to exclude or include specified machines explicitly. * Add checkpoint restarts for ufs-cpld (ufs-community#342) * Adds 3 checkpoint restart tests for the ufs-cpld model * Drops the existing c92mx025 restart test * Adds cheyenne.intel as tested configuration for ufs-cpld and ufs-datm * Fixes instances of srf_data* in various fv3_conf files * add frac grid input, update and add additional cpld tests (ufs-community#354) * Updates FV3_input_frac to add both benchmark dates and L127 files * Adds additional tests and restart tests for coupled model * Sets all cpld tests to use frac grid input by default * Removes all instances of USE_LA_LI2016=True except for benchmark+wave configurations * Remove unnecessary SIMD instruction sets for Jet, first round of cleanup in rt.conf, initialize cld_amt to zero for regional runs (dycore) (ufs-community#353) * Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5 * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Remove tests/rt_acorn.conf and run GFS v15p2 and GFS v16beta DEBUG tests on all platforms * Implementation of CCPP timestep_init and timestep_final phases (ufs-community#337) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update submodule pointer for fv3atm; skip-ci * Don't try to compile all suites in DEBUG mode on cheyenne.intel, weird bug on compute nodes; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_cray; skip-ci * Regression test logs for cheyenne.gnu, cheyenne.intel, gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_dell_p3; skip-ci * Regression test logs for wcoss_cray and wcoss_dell_p3 * Revert change to .gitmodules and update submodule pointer for fv3atm * Update CMEPS (ufs-community#345) * Update CMEPS for recent changes, including addition of new run "post" run phases to eliminate redundant mapping, multiple ice sheet capability and ocn->land ice dynamic mapping * Add a new test fv3_gfs_v16_RRTMGP_c192L127 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Remove IPD steps 3 and 5 (ufs-community#357) Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5; skip-ci * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Update usage in rt.sh, add modulefiles/jet.intel/fv3_debug; skip-ci * CCPP is default in cmake build * Add debug modulefiles for linux.gnu and macosx.gnu * Update submodule pointer for fv3atm * Change logic in CMakeLists.txt and tests/compile.sh so that 32BIT=ON automatically sets DYN32=ON; skip-ci * Move logic to set DYN32 - depending on 32BIT setting - to fv3atm * Remove -DCCPP=ON from tests/compile.sh; update submodule pointer for fv3atm; skip-ci * point fv3 to EMC develop branch (ufs-community#377) * update cpl gfsv16 tests, rrtmgp fix and bug fixes in cmeps (ufs-community#378) * update CMEPS, fix character length error for gnu compile * add Dusan's fix for rt_utils.sh * update cpl gfsv16 tests, replace seaice_newland.grb with global_slmask.t1534.3072.1536.grb, recover input.mom6.nml.IN, update input directory, update global thread and decomp tests, update fdiag for global control * point to Dustins rrtmgp fix branch * update input directory Co-authored-by: denise.worthen <Denise.Worthen@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (ufs-community#386) * Update .gitmodules and submodule pointer for fv3atm for gsl/develop branch * RUC ice for gsl/develop (replaces #47) (#49)Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm * Update gsl/develop from develop 2020/12/08 (#50) * Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Land stochastic perturbations (#57) * dycore options to add zero-gradient BC to reconstruct interface u/v and change dz_min as input (ufs-community#369) * Update fv3atm * update ccpp control test forecast length to 24h * remove rename command * Add CI related changes * Update RT logs * Update RT log files * Add the gaea RT log file * Update the point of fv3atm * Update fv3atm Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> * MOM6 bugfixes, GFDL update, update CDMBGWD settings; fix for restart reproducibility (without waves) when USE_LA_LI2016=True, sign error on fprec passed to ocean, GFDL update, resolution dependent cdmbgwd settings (ufs-community#379) * implements two MOM6 bugfixes in the NUOPC MOM6 cap to allow restart reproducibility when USE_LA_LI2016=True and to change the sign of the latent heat flux associated with frozen precipitation (fprec) exported to MOM6 * updates MOM6 to include the GFDL 20210120 main branch which contains EMC's wave coupling code, alone with some minor code standardization and documentation * updates the cdmbgwd namelist settings for FV3 standalone tests at C96 and implements resolution dependent values for ufs-cpld tests Co-authored-by: Ali <ali.abdolali@noaa.gov> * Remove legacy gnumake build from fv3atm and NEMS, remove legacy Python 2.7 support, rename v16beta to v16 and RT updates (ufs-community#384) * Update .gitmodules and submodule pointers for fv3atm and NEMS * Remove Python 2.7 support from top-level CMakeLists.txt * Reduce forecast length of test fv3_ccpp_gfs_v16_RRTMGP_c192L127 from 24h to 12h * Rename v16beta to v16 everywhere except the public release documentation * Bugfixes and missing changes * Remove 'export CCPP_LIB_DIR=ccpp/lib' from all regression tests * Update regression test baseline date tag to 20210128; skip-ci * Update ecflow-python environment on cheyenne and jet; skip-ci * Update CMEPS for HAFS integration; add datm and coupled-model tests on Gaea (ufs-community#401) * Add HAFS support in NOAA-EMC/CMEPS * Add coupled and datm tests for Gaea.intel Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Bin Li <Bin.Li@gaea13.ncrc.gov> * Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization (remove IPD step 2) (ufs-community#407) * Regression test logs for all tier=1 platforms * updates FMS to 2020.04.01 (ufs-community#392) * updates FMS to 2020.04.01 * fixes fms_files.cmake * removes extra horiz_interp * Workaround for FMS 2020.04.01 for Cheyenne with GNU 9.1.0, incl. regression test log Co-authored-by: Mikyung Lee <mlee@Orion-login-1.HPC.MsState.Edu> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * add optional mesh in MOM6; add dz_min and min_seaice as configurable variables for coupled model (ufs-community#399) *Implements an optional setting in the cpld and datm nems.configure files to specify whether the MOM6 cap should use a mesh or a grid *Adds configurable settings for min_seaice to gfs_physics_nml and dz_min to fv_core_nml. * UGWP v0 v1 combined (ufs-community#396) - combines the changes in PRs ufs-community#360 and ufs-community#382 - adds three regression tests `fv3_ccpp_gfsv16_ugwpv1 `, `fv3_ccpp_gfsv16_ugwpv1_warmstart` and `fv3_ccpp_gfsv16_ugwpv1_debug` - contains updates and bugfixes for `nc_compare.py` and the CI tests from @MinsukJi-NOAA - update Python3 environment on jet.intel, gaea.intel, cheyenne.{intel,gnu} - turn off (again) test `fv3_ccpp_decomp` on jet.intel, this test didn't work in the past, but recently it "passed", because the error checking with `nc_compare.py` failed silently and we didn't notice it Co-authored-by: valery.yudin <valery.yudin@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> * Update regression tests from GFSv15+Thompson to GFSv16+Thompson, include "Add one regional regression test in DEBUG mode. (ufs-community#419)" (ufs-community#421) * Add one regional regression test in DEBUG mode. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update regression tests from GFSv15+Thompson to GFSv16+Thompson * Combine several COMPILE lines in tests/rt.conf and tests/rt_gnu.conf * Regression test log for cheyenne.{gnu,intel},gaea.intel, hera.gnu, jet.intel,hera.intel,orion.intel;wcoss_cray and wcoss_dell_p3; Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: jiandewang <jiande.wang@noaa.gov> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Mark Potts <33099090+mark-a-potts@users.noreply.github.com> Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: dustinswales <dustin.swales@noaa.gov> Co-authored-by: Kyle Gerheiser <3209794+kgerheiser@users.noreply.github.com> Co-authored-by: RatkoVasic-NOAA <37597874+RatkoVasic-NOAA@users.noreply.github.com> Co-authored-by: Ali.Abdolali <37336972+aliabdolali@users.noreply.github.com> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> Co-authored-by: XiaqiongZhou-NOAA <48254930+XiaqiongZhou-NOAA@users.noreply.github.com> Co-authored-by: Ali <ali.abdolali@noaa.gov> Co-authored-by: Bin Li <Bin.Li@gaea13.ncrc.gov> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com> Co-authored-by: valery.yudin <valery.yudin@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>

* upstream/develop: update MOM6 to GFDL 20210224 main branch commit (ufs-community#439) Add GNU and Cheyenne Support to Automated RT (ufs-community#444) Move Noah MP init to CCPP and update Noah MP regression tests, ice flux init bug fix in CCPP (ufs-community#425) Feature/rt automation (ufs-community#403) Update ccpp-physics. Make RRTMGP thread safe (ufs-community#418) Update regression tests from GFSv15+Thompson to GFSv16+Thompson, include "Add one regional regression test in DEBUG mode. (ufs-community#419)" (ufs-community#421) UGWP v0 v1 combined (ufs-community#396) add optional mesh in MOM6; add dz_min and min_seaice as configurable variables for coupled model (ufs-community#399) updates FMS to 2020.04.01 (ufs-community#392) Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization (remove IPD step 2) (ufs-community#407) Update CMEPS for HAFS integration; add datm and coupled-model tests on Gaea (ufs-community#401) Remove legacy gnumake build from fv3atm and NEMS, remove legacy Python 2.7 support, rename v16beta to v16 and RT updates (ufs-community#384) MOM6 bugfixes, GFDL update, update CDMBGWD settings; fix for restart reproducibility (without waves) when USE_LA_LI2016=True, sign error on fprec passed to ocean, GFDL update, resolution dependent cdmbgwd settings (ufs-community#379) dycore options to add zero-gradient BC to reconstruct interface u/v and change dz_min as input (ufs-community#369) Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (ufs-community#386) update cpl gfsv16 tests, rrtmgp fix and bug fixes in cmeps (ufs-community#378) point fv3 to EMC develop branch (ufs-community#377) Remove IPD steps 3 and 5 (ufs-community#357) Update CMEPS (ufs-community#345) Implementation of CCPP timestep_init and timestep_final phases (ufs-community#337) Remove unnecessary SIMD instruction sets for Jet, first round of cleanup in rt.conf, initialize cld_amt to zero for regional runs (dycore) (ufs-community#353) add frac grid input, update and add additional cpld tests (ufs-community#354) Add checkpoint restarts for ufs-cpld (ufs-community#342) Update the format of rt.conf (ufs-community#349) Remove IPD (step 1) (ufs-community#331) Feature/ww3update (ufs-community#334) Replace old regional SDF with FV3_GFS_v15_thompson_mynn (ufs-community#333) Update modules with hpc-stack v1.1.0 (ufs-community#319) Regression test log for PR ufs-community#323 for jet.intel (ufs-community#336) RRTMGP and Thompson MP coupling (ufs-community#323) Add 2 new tests for DATM-MOM6-CICE6 application (ufs-community#332) Add optional bulk flux calculation in ufs-datm (ufs-community#266) Final-final GFS v16 updates / restart reproducibility bugfixes (ufs-community#325) Updates to build for JEDI linking/control, add wcoss2 (ufs-community#295) Update CICE, Move regression test input outside baseline directory (ufs-community#270) Feature/update mom6 and retain b4b results for 025x025 resolution (ufs-community#290) Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Updates to stochastic_physics_wrapper (ufs-community#280) Update develop from gsd/develop 2020/11/20: Unified gravity wave drag, updates to other GSL physics (ufs-community#297) Fix to allow quilting with non-factors for layout (ufs-community#250) rt update (ufs-community#261)

climbfuji added 2 commits December 15, 2020 09:22

Update .gitmodules and submodule pointer for fv3atm for code review a…

3d7e07b

…nd testing

Make CCPP=Y the default in tests/compile.sh; remove CCPP=Y from tests…

ed5869b

…/rt*conf and adjust formatting

This was referenced Dec 15, 2020

Mersenne mind twister #324

Closed

Remove IPD (step 1) NOAA-EMC/fv3atm#215

Merged

climbfuji marked this pull request as ready for review December 15, 2020 16:36

climbfuji added 4 commits December 15, 2020 13:23

Bugfix in compile.sh: CCPP_SUITES argument not extracted correctly if…

0b2bab5

… it is the first argument

Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…

01758ac

…r-model into remove_ipd

Update submodule pointer for fv3atm

999036b

Bugfix in tests/rt.sh: CCPP=Y is no longer part of MAKEOPT

79fd1f7

DusanJovic-NOAA reviewed Dec 16, 2020

View reviewed changes

junwang-noaa reviewed Dec 16, 2020

View reviewed changes

tests/compile.sh Show resolved Hide resolved

climbfuji changed the title ~~Remove IPD~~ Remove IPD (step 1) Dec 16, 2020

Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…

6c3e5fa

…r-model into remove_ipd

climbfuji added 2 commits December 28, 2020 08:24

Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…

ba6e1fd

…r-model into remove_ipd

Update submodule pointer for MOM6 to point to current head of dev/emc…

f696c87

…; skip-ci

climbfuji added No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Dec 28, 2020

Update submodule pointer for fv3atm; skip-ci

6733f63

This was referenced Dec 28, 2020

Removed use of mpp_node for use with FMS 2020.04 NOAA-EMC/GFDL_atmos_cubed_sphere#48

Merged

update MOM6 to GFDL's 20201218 commit #341

Closed

Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…

1bed095

…r-model into remove_ipd

Fix unit tests

ad32c94

climbfuji mentioned this pull request Dec 28, 2020

utest broken with WW3 update #348

Closed

climbfuji added 2 commits December 28, 2020 14:39

Unit test logs for hera.intel (update) and hera.gnu (new)

674b865

Copy modulefiles/wcoss_cray/fv3 to modulefiles/wcoss_cray/fv3_debug

89bb44a

climbfuji added 4 commits December 28, 2020 17:00

Regression test logs for cheyenne.gnu, cheyenne.intel, gaea.intel, he…

f594dff

…ra.gnu, hera.intel, orion.intel, wcoss_dell_p3; skip-ci

Increase wallclock time for fv3_ccpp_regional_quilt and fv3_ccpp_regi…

8503101

…onal_quilt_netcdf_parallel (timeout on jet); skip-ci

Regression test logs for jet.intel and wcoss_cray; skip-ci

4b9e8a0

Revert change to .gitmodules and update submodule pointer for fv3atm

68805a8

climbfuji added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Dec 29, 2020

DusanJovic-NOAA approved these changes Dec 29, 2020

View reviewed changes

DusanJovic-NOAA merged commit cfe6ed2 into ufs-community:develop Dec 29, 2020

This was referenced Dec 29, 2020

Remove IPD NOAA-EMC/fv3atm#214

Closed

Implementation of CCPP timestep_init and timestep_final phases #337

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove IPD (step 1) #331

Remove IPD (step 1) #331

climbfuji commented Dec 15, 2020 •

edited

Loading

DusanJovic-NOAA Dec 16, 2020

climbfuji Dec 16, 2020

junwang-noaa Dec 16, 2020

climbfuji Dec 16, 2020

junwang-noaa Dec 16, 2020

climbfuji Dec 16, 2020

junwang-noaa Dec 16, 2020

climbfuji Dec 16, 2020

climbfuji Dec 29, 2020

junwang-noaa Dec 16, 2020

climbfuji Dec 16, 2020

junwang-noaa commented Dec 20, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 29, 2020

Remove IPD (step 1) #331

Remove IPD (step 1) #331

Conversation

climbfuji commented Dec 15, 2020 • edited Loading

Description

Issue(s) addressed

Testing

Dependencies

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junwang-noaa commented Dec 20, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 28, 2020

climbfuji commented Dec 29, 2020

climbfuji commented Dec 15, 2020 •

edited

Loading