To update FV3 dynamic core to the GFDL 201912 released version #58

XiaqiongZhou-NOAA · 2020-02-13T20:40:58Z

To update FV3 dynamic core to the GFDL 201912 released version,
the namelist files in ~parm should be revised due to the namelist changes for nesting

Related pull requests:
atmos_cubed_sphere #15
fv3atm #65
ccpp-physics #397

… in atmos_cubed_sphere

Merge https://github.com/ufs-community/ufs-weather-model

…N=Y (DEFAULT).Startinging with FMS 2019.01.01, quad-precision arithmetic is enabled it the ENABLE_QUAD_PRECISION macro. This is used to determine whether certain grid metric terms code within FMS/FV3-dycore use quad-precision arithmetic.

climbfuji

A few comments, no show stoppers, but I would like to hear back if possible. If any changes/updates are needed those can be done on a follow-up PR.

climbfuji · 2020-06-10T17:01:04Z

cmake/Intel.cmake

@@ -50,6 +50,10 @@ if(OPENMP)
    add_definitions(-DOPENMP)
 endif()

+if(QUAD_PRECISION)
+    add_definitions(-DENABLE_QUAD_PRECISION)


Why is there no

message("QUAD_PRECISION is ENABLED")

?

I see it further down, why not make the same change as for GNU and PGI?

climbfuji · 2020-06-10T17:02:49Z

cmake/configure_cheyenne.gnu.cmake

@@ -16,6 +16,7 @@ option(VERBOSE "Enable VERBOSE mode" OFF)
 option(32BIT   "Enable 32BIT (single precision arithmetic in dycore)" OFF)
 option(OPENMP  "Enable OpenMP threading" ON)
 option(AVX2    "Enable AVX2 instruction set" OFF)
+option(QUAD_PRECISION  "Enable QUAD_PRECISION (for certain grid metric terms in dycore)" ON)


Has anyone tested this new FMS release / quad precision flag with GNU (on cheyenne, or generic linux, or generic macOS)?

I didn't run this version with GNU compiler. If there are issues, we must fix them in the next PR.

climbfuji · 2020-06-10T17:05:14Z

parm/ccpp_regional_c768.nml.IN

@@ -36,7 +36,7 @@
 /

 &fv_core_nml
-       layout   = 24,20
+       layout   = 18,24


Why do we need to change this? Because we need to take processors away for the write component?

The layout = 24,20 in the original code guarantees uniform block size. Is this the case for 18,24 as well?

Yes, I change it to use same number of the processors while using write component.

Does this still give uniform block sizes? That is important. You can look at the out and/or err files for this job, there is a warning if non-uniform block sizes are used.

Do you mean "the non-divisible blocksize"? There is no "the non-divisible blocksize" warning as the write component has issues with it.

Each block has the uniform size.

Thanks for clarifying!

climbfuji · 2020-06-10T17:06:59Z

tests/tests/fv3_ccpp_stretched_nest_quilt

@@ -13,7 +13,7 @@ export LIST_FILES="  atmos_4xdaily.tile1.nc \
                     atmos_4xdaily.tile4.nc \
                     atmos_4xdaily.tile5.nc \
                     atmos_4xdaily.tile6.nc \
-              atmos_4xdaily.nest02.tile7.nc \
+                    atmos_4xdaily.nest02.nc \


Note that this test is not exercised in rt.conf.

junwang-noaa · 2020-06-10T17:15:50Z

conf/configure.fv3.wcoss_phase1

@@ -18,6 +18,7 @@ REPRO =
 VERBOSE =
 OPENMP = Y
 HYDRO = N
+QUAD_PRECISION = Y


wcoss_phase1/2 is not supported any more. We will plan to remove wcoss phase1/2 related files.

junwang-noaa · 2020-06-10T17:17:08Z

conf/configure.fv3.wcoss_cray

@@ -21,6 +21,7 @@ OPENMP = Y
 AVX2 = Y
 HYDRO = N
 CCPP = N
+QUAD_PRECISION = Y


With this setting QUAD_PRECISION is set to Y, will all the RT test results be changed on cray?

No. Only atmos_4xdaily.* files are changed due to change in netcdf file format in FMS.

junwang-noaa · 2020-06-10T17:19:11Z

tests/rt.sh

@@ -378,9 +378,9 @@ while getopts ":cfsl:mkreh" opt; do
 done

 if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]]; then
-  RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-20200603/${COMPILER^^}}
+  RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-20200608/${COMPILER^^}}


May I ask what regression test results are changed with this commit from 20200603 to 20200608 on platform hera, dell, cray and orion?

All nesting and regional tests will have different results. also atmos_4xdaily.tile?.nc has identical fields but the head differ.

All atmos_4xdaily.* files are changed in all tests that write out those files. Then in regional_768 test we switched from using diag_manager to write component.

junwang-noaa

I have some questions on the impact of results. The code change itself looks good.

junwang-noaa · 2020-06-10T17:26:31Z

So only atmos_4xdaily files are different with the FMS version update from 2019.0.1 to 2020.02 on all the platforms (orion/hera/dell/cray)?

…

On Wed, Jun 10, 2020 at 1:23 PM Dusan Jovic ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In conf/configure.fv3.wcoss_cray <#58 (comment)> : > @@ -21,6 +21,7 @@ OPENMP = Y AVX2 = Y HYDRO = N CCPP = N +QUAD_PRECISION = Y No. Only atmos_4xdaily.* files are changed due to change in netcdf file format in FMS. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#58 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TM6JQZ2JNQHLIWMCNTRV66QZANCNFSM4KU2RPWQ> .

junwang-noaa · 2020-06-10T17:55:00Z

*@climbfuji* Yes, I checked with dimension (1728, 1440), the layout gives uniform block size.

…

On Wed, Jun 10, 2020 at 1:52 PM XiaqiongZhou-NOAA ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In parm/ccpp_regional_c768.nml.IN <#58 (comment)> : > @@ -36,7 +36,7 @@ / &fv_core_nml - layout = 24,20 + layout = 18,24 Do you mean "the non-divisible blocksize"? There is no "the non-divisible blocksize" warning as the write component has issues with it. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#58 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TO737QN7J3N5YBVEH3RV7B7PANCNFSM4KU2RPWQ> .

…ointer_fv3atm Update submodule pointer fv3atm 2020/07/01

…ase/public-v2 Revert "merge ufs-release/public-v2 -> dev/emc"

XiaqiongZhou-NOAA added 13 commits January 9, 2020 13:56

point to my own fork

38de896

update FMS

24e915f

update FV3

0403d22

point FMS to personal fork/branch

de0392c

Change input namlist for nesting corresponding to the namelist change…

73fd25d

… in atmos_cubed_sphere

Change FMS to a older revision that works

2b12849

Change nest namelist with CCPP; update FV3 version

c57aad0

update to latest ufs_weather_model

dc370ae

update FV3

698f3e6

update stochastic_physics

708e460

Update WW3

6b4e601

point to new version

c4a351d

Merge remote-tracking branch 'emc/develop' into develop

55b6ba1

Merge https://github.com/ufs-community/ufs-weather-model

XiaqiongZhou-NOAA marked this pull request as ready for review February 13, 2020 21:17

XiaqiongZhou-NOAA requested a review from junwang-noaa February 13, 2020 21:17

XiaqiongZhou-NOAA added 12 commits May 5, 2020 13:07

merger ufs-community/ufs-weather-model develop branch

2c33839

Move to submodule FMS to the 2020.02 version and FV3 to latest

cc82f8c

update FV3 to a new version

b1e168a

Merge remote-tracking branch 'ufscomm/develop' into develop

af020dd

Point submodules to new version

985a0bd

Merge remote-tracking branch 'ufscommunity/develop' into develop

081109b

Fix an error

0ddf6df

Point FV3 submodule to a new version

d993d2a

Revise CMakeList to work with FMS 2020.02

3a9c1ab

Change the nesting history output names; Point FV3 to a new version

60ddf0e

Point to the updated fv3atm and SP submodules

fee9ce2

XiaqiongZhou-NOAA added 10 commits May 27, 2020 17:58

Merge remote-tracking branch 'ufscomm/develop' into develop

cb1e90d

To use write component instead of FMS2 IO for ccpp_regional_c768

8d3bc8e

Merge remote-tracking branch 'ufscomm/develop' into develop

c52fdef

Update submodules

da0e33a

Merge ufs-community

fc17238

Update the FV3 version

05f96a6

Update log files

81495d5

update rt.sh

757c648

Update the submodule fv3atm to the public version

8bdacb1

Point FV3 to the public version

37ccd2f

DusanJovic-NOAA requested a review from climbfuji June 10, 2020 16:49

climbfuji approved these changes Jun 10, 2020

View reviewed changes

junwang-noaa reviewed Jun 10, 2020

View reviewed changes

junwang-noaa approved these changes Jun 10, 2020

View reviewed changes

DusanJovic-NOAA merged commit 9e3aedc into ufs-community:develop Jun 10, 2020

junwang-noaa mentioned this pull request Jun 18, 2020

fixing delz in the restart file for regional fv3 #150

Closed

climbfuji added a commit to climbfuji/ufs-weather-model that referenced this pull request Jul 7, 2020

Merge pull request ufs-community#58 from climbfuji/update_submodule_p…

1b7b0e2

…ointer_fv3atm Update submodule pointer fv3atm 2020/07/01

junwang-noaa mentioned this pull request Mar 2, 2021

the coupled model requires FV3 and CMEPS updates for frac grid normalization #366

Closed

LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/ufs-weather-model that referenced this pull request Oct 22, 2021

Merge pull request ufs-community#58 from NOAA-GFDL/revert-57-ufs-rele…

7ccf953

…ase/public-v2 Revert "merge ufs-release/public-v2 -> dev/emc"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

To update FV3 dynamic core to the GFDL 201912 released version #58

To update FV3 dynamic core to the GFDL 201912 released version #58

XiaqiongZhou-NOAA commented Feb 13, 2020 •

edited

Loading

climbfuji left a comment

climbfuji Jun 10, 2020

climbfuji Jun 10, 2020

climbfuji Jun 10, 2020

DusanJovic-NOAA Jun 10, 2020

climbfuji Jun 10, 2020

XiaqiongZhou-NOAA Jun 10, 2020

climbfuji Jun 10, 2020

XiaqiongZhou-NOAA Jun 10, 2020

XiaqiongZhou-NOAA Jun 10, 2020

climbfuji Jun 10, 2020

climbfuji Jun 10, 2020

junwang-noaa Jun 10, 2020

junwang-noaa Jun 10, 2020

DusanJovic-NOAA Jun 10, 2020

junwang-noaa Jun 10, 2020

XiaqiongZhou-NOAA Jun 10, 2020

DusanJovic-NOAA Jun 10, 2020

junwang-noaa left a comment

junwang-noaa commented Jun 10, 2020 via email

junwang-noaa commented Jun 10, 2020 via email

To update FV3 dynamic core to the GFDL 201912 released version #58

To update FV3 dynamic core to the GFDL 201912 released version #58

Conversation

XiaqiongZhou-NOAA commented Feb 13, 2020 • edited Loading

climbfuji left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junwang-noaa left a comment

Choose a reason for hiding this comment

junwang-noaa commented Jun 10, 2020 via email

junwang-noaa commented Jun 10, 2020 via email

XiaqiongZhou-NOAA commented Feb 13, 2020 •

edited

Loading