-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional scaling to RRTMGP flux adjustment #605
Closed
dustinswales
wants to merge
8
commits into
ufs-community:develop
from
dustinswales:hotfix_AddPLimitToLWJacAdj
Closed
Add optional scaling to RRTMGP flux adjustment #605
dustinswales
wants to merge
8
commits into
ufs-community:develop
from
dustinswales:hotfix_AddPLimitToLWJacAdj
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Limit Jacobian Flux adjustment to below 100hPa.
…dded default values to c192l127 GP RT
climbfuji
approved these changes
May 27, 2021
Dustin, would you please sync your code with the latest develop branch? Thanks |
I'll take care of this when I pull in the code changes from Dustin into a combined PR.
… On Jun 24, 2021, at 7:24 PM, Jun Wang ***@***.***> wrote:
Dustin, would you please sync your code with the latest develop branch? Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#605 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RL6A2FRUM47BM3JLWDTUPLGLANCNFSM45UTOHSQ>.
|
This PR has been pulled into #658 and will be merged as part of it. |
This PR was merged as part of #619 |
pjpegion
pushed a commit
to NOAA-PSL/ufs-weather-model
that referenced
this pull request
Apr 4, 2023
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
…les for verification (#605) This PR allows the SRW App to run the WE2E test that performs deterministic verification using staged forecast files (MET_verification_only_vx) using files in the authoritative location on a given platform (instead of in a user's directory). This is done by: 1) Specifying the location of the staged forecast files in the machine file (for this PR, it is specified only for Hera) via the new variable TEST_VX_FCST_INPUT_BASEDIR. 2) Modifying run_WE2E_tests.py so that it correctly sets the variable containing this location (VX_FCST_INPUT_BASEDIR). Depending on the experiment configuration, VX_FCST_INPUT_BASEDIR may be set using the value in the test configuration file, the machine file, or the default experiment configuration file. 3) Modifying the configuration file for the WE2E test MET_verification_only_vx so that it does not specify a user directory for VX_FCST_INPUT_BASEDIR (as well as for CCPA_OBS_DIR, MRMS_OBS_DIR, and NDAS_OBS_DIR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains improvements to how the LW heating-rate profile is updated between calls to the RRTMGP radiation scheme.
The adjusted net LW flux is computed following Hogan and Bozzo 2015 (10.1002/2015MS000455). Optionally, the flux adjustment can be damped with height using a logistic function.
Testing
This was tested on Hera using the Intel compilers. Baselines for the c192l127 RRTMGP regression test will need to be updated.
Dependencies
https://github.com/dustinswales/fv3atm/tree/hotfix_AddPLimitToLWJacAdj
https://github.com/dustinswales/ccpp-physics/tree/hotfix_AddPLimitToLWJacAdj
Waiting for other repos
NOAA-EMC/fv3atm#319
NCAR/ccpp-physics#668