Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional scaling to RRTMGP flux adjustment #605

Closed
wants to merge 8 commits into from
Closed

Add optional scaling to RRTMGP flux adjustment #605

wants to merge 8 commits into from

Conversation

dustinswales
Copy link
Collaborator

Description

This PR contains improvements to how the LW heating-rate profile is updated between calls to the RRTMGP radiation scheme.
The adjusted net LW flux is computed following Hogan and Bozzo 2015 (10.1002/2015MS000455). Optionally, the flux adjustment can be damped with height using a logistic function.

Testing

This was tested on Hera using the Intel compilers. Baselines for the c192l127 RRTMGP regression test will need to be updated.

Dependencies

https://github.com/dustinswales/fv3atm/tree/hotfix_AddPLimitToLWJacAdj
https://github.com/dustinswales/ccpp-physics/tree/hotfix_AddPLimitToLWJacAdj

Waiting for other repos

NOAA-EMC/fv3atm#319
NCAR/ccpp-physics#668

@junwang-noaa
Copy link
Collaborator

Dustin, would you please sync your code with the latest develop branch? Thanks

@climbfuji
Copy link
Collaborator

climbfuji commented Jun 25, 2021 via email

@climbfuji
Copy link
Collaborator

This PR has been pulled into #658 and will be merged as part of it.

@climbfuji
Copy link
Collaborator

This PR was merged as part of #619

@climbfuji climbfuji closed this Jul 12, 2021
@dustinswales dustinswales deleted the hotfix_AddPLimitToLWJacAdj branch September 21, 2021 15:43
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
…les for verification (#605)

This PR allows the SRW App to run the WE2E test that performs deterministic verification using staged forecast files (MET_verification_only_vx) using files in the authoritative location on a given platform (instead of in a user's directory). This is done by:

1) Specifying the location of the staged forecast files in the machine file (for this PR, it is specified only for Hera) via the new variable TEST_VX_FCST_INPUT_BASEDIR.
2) Modifying run_WE2E_tests.py so that it correctly sets the variable containing this location (VX_FCST_INPUT_BASEDIR). Depending on the experiment configuration, VX_FCST_INPUT_BASEDIR may be set using the value in the test configuration file, the machine file, or the default experiment configuration file.
3) Modifying the configuration file for the WE2E test MET_verification_only_vx so that it does not specify a user directory for VX_FCST_INPUT_BASEDIR (as well as for CCPA_OBS_DIR, MRMS_OBS_DIR, and NDAS_OBS_DIR).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants