flexible output hour for history files and and update MOM6 to GFDL 20210723

[junwang-noaa]

PR Checklist

• Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
  are specified below.

• [] If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

In this PR, model is allowed to output history files at flexible (random) forecast hours.

• fdiag, fhout,fhmax, fhouthf, and fhmaxhf are removed from fv3 namelist atmos_model_nml. With the code updates, those variables should be deleted from namelist.
• in model_configure, output_fh is added to control flexible output forecast time
• The usage of restart_interval is updated to be consistent with outout_fh
• A new test control_fhzero is added. Because of this test, control test will have the history files saved at fh=21 so that those history files can be used to compare with those from control_fhzero.
• update MOM6 to GFDL 20210723 from @jiandewang
• Move to using hecflow01 on hera from @BrianCurtis-NOAA
• CI test update from @MinsukJi-NOAA

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.

• fixes #339
• fixes #674
• fixes #583
• fixes #706
• fixes #710

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel (skipped, machine down all week)
• cheyenne.gnu (skipped, machine down all week)
• gaea.intel
• jet.intel
• wcoss_cray
• wcoss_dell_p3
• CI: https://github.com/ufs-community/ufs-weather-model/actions/runs/1068770647

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

• waiting on fv3atm PR#345
• waiting on MOM6 PR#71

[BrianCurtis-NOAA]

Machine: hera
Compiler: intel
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/690827652/20210726193041/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_7895
Please make changes and add the following label back:
hera-intel-BL

[BrianCurtis-NOAA]

Machine: hera
Compiler: intel
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/690827652/20210726193041/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_7895
Please make changes and add the following label back:
hera-intel-BL

Looks like the BL tag was added by accident. Colors are too close I guess. Fixed that.

[BrianCurtis-NOAA]

Machine: jet
Compiler: intel
Job: RT
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/690827652/20210726191521/ufs-weather-model
Please manually delete: /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_298242
Test datm_control_gefs 082 failed in run_test failed
Test datm_cdeps_bulk_gefs 093 failed in run_test failed
Please make changes and add the following label back:
jet-intel-RT

[DeniseWorthen]

Both job failures on jet were sbatch: error: Batch job submission failed: Socket timed out on send/recv operation

[DeniseWorthen]

Changes look good. I do think we need good documentation to allow users to take advantage of the feature.

[DusanJovic-NOAA]

Not used anymore. Can be removed in one of the future PRs.

[junwang-noaa]

Both job failures on jet were sbatch: error: Batch job submission failed: Socket timed out on send/recv operation

I reran the two tests, both passed on jet.

Compile 001 elapsed time 259 seconds. -DAPP=NG-GODAS-NEMSDATM -DMPI=ON -DCMAKE_BUILD_TYPE=Release -DSIMDMULTIARCH=ON -DMOM6SOLO=ON
Compile 002 elapsed time 259 seconds. -DAPP=NG-GODAS -DMPI=ON -DCMAKE_BUILD_TYPE=Release -DSIMDMULTIARCH=ON -DMOM6SOLO=ON

baseline dir = /lfs4/HFIP/h-nems/emc.nemspara/RT/NEMSfv3gfs/develop-20210722/INTEL/datm_control_gefs
working dir = /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_92768/datm_control_gefs
Checking test 001 datm_control_gefs results ....
Comparing RESTART/MOM.res.nc ............ALT CHECK......OK
Comparing RESTART/iced.2011-10-02-00000.nc .........OK
Comparing RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc .........OK

0: The total amount of wall time = 118.220097
Test 001 datm_control_gefs PASS

baseline dir = /lfs4/HFIP/h-nems/emc.nemspara/RT/NEMSfv3gfs/develop-20210722/INTEL/datm_cdeps_bulk_gefs
working dir = /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_92768/datm_cdeps_bulk_gefs
Checking test 002 datm_cdeps_bulk_gefs results ....
Comparing RESTART/MOM.res.nc ............ALT CHECK......OK
Comparing RESTART/iced.2011-10-02-00000.nc .........OK
Comparing RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc .........OK

0: The total amount of wall time = 191.770578
Test 002 datm_cdeps_bulk_gefs PASS

[climbfuji]

I didn't read the code carefully, it seems. Does -1 mean at the end of the forecast run?

[junwang-noaa]

Is the second element is "-1", it means the first element is a restart frequency. RESTART_INTERVAL="12" means writing out restart at fh=12.

…

On Tue, Jul 27, 2021 at 10:09 AM Dom Heinzeller ***@***.***> wrote: ***@***.**** approved this pull request. ------------------------------ In tests/tests/control <#691 (comment)> : > @@ -57,7 +61,7 @@ export SYEAR=2021 export SMONTH=03 export SDAY=22 export SHOUR=06 -export RESTART_INTERVAL=12 +export RESTART_INTERVAL="12 -1" I didn't read the code carefully, it seems. Does -1 mean at the end of the forecast run? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#691 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TOVG23TQ6FERFD74S3TZ24XLANCNFSM5ANZIJOA> .