Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, remove snet from noah lsm, fix time dimension in restart files, rt.sh bugfix for PBS, and more! #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_utils.sh to crrectly detect failed jobs on Cheyenne, comment out coupled debug tests in rt_gnu.conf, update BL_DATE in rt.sh
climbfuji
changed the title
This was referenced Jul 22, 2021
…r-model into thompson_inner_loop_subcycling_bugfix_noah_bugfix_gnu_compile_pbs_fix
climbfuji
added
Baseline Updates
|
CI tests reported failure of: |
HelinWei-NOAA
approved these changes
Jul 22, 2021
tests/rt_gnu.conf
Outdated
| @@ -64,8 +66,8 @@ RUN | fv3_esg_HAFS_v0_hwrf_thompson_debug | |||
| COMPILE | -DAPP=S2S -DCCPP_SUITES=FV3_GFS_2017_coupled | | fv3 | | |||
There was a problem hiding this comment.
This compile will also fail on cheyenne.gnu. Should we just add -chyenne.gnu to cpld_control, cpld_debug and ng-gdas-nemsdatm since they compile and run on hera.gnu
There was a problem hiding this comment.
Yes, this is what I did in my first round of bug fixes - thanks. Let's see if the bug fixes in FV3GFS_io.F90 resolve the restart issue for the coupled tests.
|
CI tests passed for 5816815 - means the coupled control restart run is fixed. @junwang-noaa @pjpegion @lisa-bengtsson I tried to add the stochy and ca debug tests for the GNU compiler. Both tests crashed on Cheyenne with GNU 10.
The tests didn't fail with Intel. I am going to comment them out again in |
climbfuji
requested review from
junwang-noaa,
DusanJovic-NOAA,
BrianCurtis-NOAA and
MinsukJi-NOAA
junwang-noaa
approved these changes
Jul 23, 2021
MinsukJi-NOAA
approved these changes
Jul 23, 2021
DusanJovic-NOAA
approved these changes
Jul 23, 2021
BrianCurtis-NOAA
approved these changes
Jul 23, 2021
…ompile_pbs_fix' of https://github.com/climbfuji/ufs-weather-model into thompson_inner_loop_subcycling_bugfix_noah_bugfix_gnu_compile_pbs_fix
|
Regression testing complete. |
climbfuji
added
the
Ready for Commit Queue
|
Ready for commit whenever you are. If you want to run CI tests again, please let me know. Thanks! |
I don't think we need to run CI again. |
14 tasks
14 tasks
5 tasks
BinLiu-NOAA
added a commit
to hafs-community/HAFS
that referenced
this pull request
Aug 13, 2021
Sync HAFS submodules with their corresponding authoritative branches: - hafs_forecast.fd as of 08/05/2021 - hafs_gsi.fd as of 08/06/2021 plus the dual-resolution 3DEnVar bug fix - hafs_post.fd as of 08/02/2021 - hafs_utils.fd as of as of 07/23/2021 - hafs_graphics.fd/hrd_gplot as of 08/10/2021 - hafs_graphics.fd/emc_graphics as of 08/10/2021 Besides application level changes were made accordingly with the updated submodules. This PR addresses issue #80. Notes: - The [bug of wrong Time dimension in FV3 restart sfc_data files](NOAA-EMC/fv3atm#344) has been fixed in ufs-weather-model through this ufs-weather-model [PR](ufs-community/ufs-weather-model#702). - The bug fix in for the dual-resolution EnVar analysis in GSI (hafs_gsi.fd) contributed from OU collaborators has also been included in this PR. With that the HAFS ENSDA configurations can now work properly. - As for the hafs_forecast.fd submodule, support/HAFS branch is identical to the ufs-weather-model develop branch as of 08/05/2021. More information can be found through this PR (ufs-community/ufs-weather-model#715)
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
…hysics seed generation script (#704) ## DESCRIPTION OF CHANGES: Add missing user-defined options for tendency-based stochastic physics and fix the ensemble-based seed generation script to work regardless of whether stochastic physics is turned on or not. ## TESTS CONDUCTED: Tested on Hera using the following WE2E configurations with and without stochastic physics: config.grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_HRRR.sh config.community_ensemble_2mems.sh ## ISSUE (optional): [Issue #702](ufs-community/regional_workflow#702) ## CONTRIBUTORS (optional): Thanks to @mkavulich and @chan-hoo for finding this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
[n/a] If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR combines many changes:
rt_utils.shto correctly detect job failures on Cheyenne with PBS, turn off coupled debug compilation/tests for GNU. which now fail, same for testcontrol_csawmg; from @DeniseWorthen and @DusanJovic-NOAArt.confandrt_gnu.conffrom @junwang-noaacontrol_stochy_debugandcontrol_ca_debugstill not working with GNUrt.conf) from @junwang-noaaThe changes in fv3atm and ccpp-physics do change the results of all regression tests, new baseline date is 20210721.
Issue(s) addressed
Fixes #697
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
NCAR/ccpp-physics#702
NOAA-EMC/fv3atm#350
#702