-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HAFS HYCOM, WW3 and CDEPS_DOCN coupling related documentation #864
Add HAFS HYCOM, WW3 and CDEPS_DOCN coupling related documentation #864
Conversation
* add to code overview * added build settings for HAFS and HAFSW * added app names HAFS and HAFSW * new section for HYCOM input * added blkdat.input to list of files * added HAFS application sample * new section added to point to external blkdat.input documentation * new section for HYCOM output Co-authored-by: Bin Liu <Bin.Liu@noaa.gov> Co-authored-by: Hyun-Sook Kim <hyun.sook.kim@noaa.gov>
@rmontuoro FYI, here is HYCOM documentation PR. |
In inputs.outputs.rst, the application 'HAFS-ALL" is missing in the list of supported ufs-weather-model applications. |
* add HAFS-ALL app * update HYCOM blkdat.input setting descriptions
@BinLiu-NOAA Done |
@danrosen25 I think I created initial version of WW3 document and you could find it in the following link, https://docs.google.com/document/d/1pS0MQdenb6XsuuJ9y8lyUJsQ5q3mg3kn-T9uKmWkAZI/edit It might help. |
The ufs-weather-model documentation is focused on building forecast apps and the input and output for each app. It's a user's guide. |
mod_def.<grd> files must be consistent with version of the code.
…doc_hafs_hycom_docn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@binli2337 Can you confirm that this PR is ready to go? @JessicaMeixner-NOAA @junwang-noaa please check again and approve if ok. Thanks! |
@BinLiu-NOAA Ready to merge? |
@climbfuji, I think it is ready to merge. Thanks! |
@rmontuoro HAFS documentation merged - your turn please! |
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR addresses missing documentation for HAFS related HYCOM, CDEPS-DOCN and WW3 coupling.
Co-authored-by: @BinLiu-NOAA, @hyunsookkim-NOAA, @uturuncoglu, @JessicaMeixner-NOAA, @aliabdolali
Issue(s) addressed
Testing
Dependencies