Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve logic for convective transportable tracers in CCPP, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic" #875

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 18, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

Update submodule pointers for fv3atm and ccpp-physics for the changes described in the associated PRs below: fix/improve logic for convective transportable tracers in CCPP, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic" in several CCPP standard names.

No changes to the regression test results, no new input data.

Issue(s) addressed

Fixes NCAR/ccpp-physics#751

Testing

Preliminary regression tests were run on Hera with Intel, all tests pass. Full regression tests will be run on all tier-1 platforms when it is time to commit.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

NCAR/ccpp-physics#752
NOAA-EMC/fv3atm#413
#875

@climbfuji climbfuji changed the title Fix/improve logic for convective transportable tracers in CCPP, add GFS_checktracer debugging routine Fix/improve logic for convective transportable tracers in CCPP, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic" Oct 19, 2021
@junwang-noaa
Copy link
Collaborator

Combined in PR#892, which was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic for convective transportable tracers needs to be improved
2 participants