Remove optional arguments from CCPP framework/metadata #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-model into remove_optional_arguments_from_ccpp
This was referenced Oct 25, 2021
Merged
14 tasks
|
Combined in PR#892, which was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR updates the submodule pointers for fv3atm, ccpp-framework and ccpp-physics to:
optionalattribute in the CCPP framework and metadataoptionalandintentattributes from host model metadata (variable or type definitions)No changes to the regression test results or the input data.
Issue(s) addressed
Fixes NCAR/ccpp-framework#407
Testing
Regression tests were run on 10/25/2021 on Gaea/Intel against the existing baseline, all tests passed.
Full regression tests will be run on all tier-1 platforms when it is time to commit.
Dependencies
NCAR/ccpp-framework#408
earth-system-radiation/rte-rrtmgp#143
NCAR/ccpp-physics#763
NOAA-EMC/fv3atm#415
#887
Associated SCM PR: MISSING