Merge branch 'DataEx_1' into 'master'

[DataExplorer] small fix in TranslateDataDialog See merge request ogs/ogs!4673
ufz · Jul 17, 2023 · 065b669 · 065b669
2 parents 26e7598 + 57216b1
commit 065b669
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/Applications/DataExplorer/DataView/TranslateDataDialog.cpp b/Applications/DataExplorer/DataView/TranslateDataDialog.cpp
@@ -24,6 +24,18 @@
 #include "MeshModel.h"
 #include "MeshToolsLib/MeshEditing/moveMeshNodes.h"
 
+namespace
+{
+std::vector<std::string> getSelectedObjects(
+ QStringList const& list)
+{
+ std::vector<std::string> indexList;
+ std::transform(list.begin(), list.end(), std::back_inserter(indexList),
+ [](auto const& index) { return index.toStdString(); });
+ return indexList;
+}
+} // namespace
+
 TranslateDataDialog::TranslateDataDialog(MeshModel* mesh_model,
  GEOModels* geo_models,
  QDialog* parent)
@@ -151,7 +163,7 @@ void TranslateDataDialog::accept()
  displacement[2]);
 
  std::vector<std::string> const selectedData =
- this->getSelectedObjects(_selData.stringList());
+ getSelectedObjects(_selData.stringList());
 
  auto const geoNames = _geo_models->getGeometryNames();
 
@@ -167,13 +179,4 @@ void TranslateDataDialog::accept()
  }
 
  this->done(QDialog::Accepted);
-}
-
-std::vector<std::string> TranslateDataDialog::getSelectedObjects(
- QStringList list)
-{
- std::vector<std::string> indexList;
- std::transform(list.begin(), list.end(), std::back_inserter(indexList),
- [](auto const& index) { return index.toStdString(); });
- return indexList;
 }
diff --git a/Applications/DataExplorer/DataView/TranslateDataDialog.h b/Applications/DataExplorer/DataView/TranslateDataDialog.h
@@ -43,7 +43,6 @@ class TranslateDataDialog : public QDialog, private Ui_TranslateData
  QDialog* parent = nullptr);
 
 private:
- std::vector<std::string> getSelectedObjects(QStringList list);
  void moveGeometry(Eigen::Vector3d const& displacement,
  std::string const& name);
  void moveMesh(Eigen::Vector3d const& displacement, std::string const& name);