Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: normalization mean and var in sinergym output #409

Closed
2 tasks done
AlejandroCN7 opened this issue Apr 25, 2024 · 0 comments · Fixed by #411
Closed
2 tasks done

[Enhancement]: normalization mean and var in sinergym output #409

AlejandroCN7 opened this issue Apr 25, 2024 · 0 comments · Fixed by #411
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request wrapper Everything related to wrappers

Comments

@AlejandroCN7
Copy link
Member

AlejandroCN7 commented Apr 25, 2024

Improvement 🔧

As described in version 3.3.1, functionality has been added to save calibration configurations for adaptive observation normalization.

However, its logging and usage in the Sinergym tool can be improved for better usability, hence the following enhancements are proposed:

  • Save the mean and variance in a text file in the Sinergym output if the normalization wrapper has been used.
  • Add an assert to provide a more precise notification if the wrapper has not been correctly indicated (in case a previous calibration is to be used).
  • Improve the example notebook to better demonstrate its use.
  • Mean and var cloud be indicated as list or numpy instead of only numpy.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)

📝 Please, don't forget to include more labels besides enhancement if it is necessary.

@AlejandroCN7 AlejandroCN7 added documentation Improvements or additions to documentation enhancement New feature or request wrapper Everything related to wrappers labels Apr 25, 2024
@AlejandroCN7 AlejandroCN7 self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request wrapper Everything related to wrappers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant