Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.3.2) - Calibration of observation normalization improvement #411

Merged
merged 10 commits into from
May 2, 2024

Conversation

AlejandroCN7
Copy link
Member

Description

This PR brings some improvements related with NormalizeObservation wrapper calibration, more information in referenced issue

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fixes #409

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • [] I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Wrapper flexibility for use list or numpy in mean and var calibration.
  • Functionality to save this values in Sinergym output folder as txt files.
  • Deleted related process in example scripts.
  • Updated wrapper documentation and notebook example explaining the use case.

@AlejandroCN7 AlejandroCN7 marked this pull request as ready for review May 2, 2024 08:15
@AlejandroCN7 AlejandroCN7 merged commit 6e87842 into main May 2, 2024
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the impr/issue-409 branch May 2, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: normalization mean and var in sinergym output
1 participant