-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v2.4.0) - Sinergym working with JSON instead of IDF to manage building models #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython dict with Energyplus epJSON standard
….building by json load, update adapt_idf_to_epw and save_building_model to save JSON file instead
…SON methodology (Dictionary structure changes lightly)
…ect (this class will not be updated anymore)
…odelIDF inheriting from that class
…d logger messages more generic
…ite some adaptations to new json methodology
…names and schedulers getter improved with simulator properties
…ibilities management included
…PIreference dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will adapt Sinergym to work with epJSON files instead of IDF files in building model's internal definition.
Motivation and Context
JSON is a universal format, better than use a specific format such as IDF. Moreover, Energyplus aims to work and support JSON over IDF.
Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.
Fixes #332
Types of changes
Checklist:
autopep8
second level aggressive.isort
.cd docs && make spelling && make html
pass (required if documentation has been updated.)pytest tests/ -vv
pass. (required).pytype -d import-error sinergym/
pass. (required)Changelog (very general, see commits):
sinergym/config/modeling.py
and updated for JSON new functionality, made the class method names more general.