Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.3.5) - Utils dependency fix #414

Merged
merged 2 commits into from
May 15, 2024
Merged

(v3.3.5) - Utils dependency fix #414

merged 2 commits into from
May 15, 2024

Conversation

AlejandroCN7
Copy link
Member

Description

This PR is a HOTFIX to modify dependency in wrappers and controllers modules, being gymnasium env instead of EplusEnv of Sinergym.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

If you want to use sinergym utils only without simulator, this change make it more comfortable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Modify utils imports (Gymnasium.env instead of sinergym.EplusEnv)

@AlejandroCN7 AlejandroCN7 merged commit f584c6b into main May 15, 2024
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the fix-dependency branch May 15, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant