Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.4.0) Sinergym parallelism on the same machine #424

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

AlejandroCN7
Copy link
Member

Description

This PR provides Sinergym with full support for multiple parallel runs on the same machine. For more information, visit the referenced issue in motivation and context.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.

Fixes #423

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Modeling: Applying fcntl functionality to output folder name creation for robust parallelism.

@AlejandroCN7 AlejandroCN7 merged commit 13df06c into main Jul 3, 2024
4 checks passed
@AlejandroCN7 AlejandroCN7 deleted the bug/issue-423 branch July 3, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unhandled Critical Section for applying parallelism in Sinergym experiments.
1 participant