Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale scores that are based on percentages by maxScore #392

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Nov 3, 2024

When maxScore=50 then the impact of 50% success should be 25.

@uhafner uhafner added the bug Bugs or performance problems label Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (91105da) to head (e9ea8d6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #392      +/-   ##
============================================
+ Coverage     85.79%   85.81%   +0.02%     
- Complexity      478      479       +1     
============================================
  Files            30       30              
  Lines          1401     1403       +2     
  Branches         82       82              
============================================
+ Hits           1202     1204       +2     
  Misses          167      167              
  Partials         32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When `maxScore=50` then the impact of 50% success should be 25.
Repository owner deleted a comment from github-actions bot Nov 3, 2024
@uhafner uhafner merged commit 17f1039 into main Nov 3, 2024
16 checks passed
@uhafner uhafner deleted the scale-max-score branch November 3, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant