Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ParameterNumber check for overridden methods #971

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Mar 30, 2024

It makes no sense to warn about the parameters in overridden methods.

@uhafner uhafner added the internal Internal changes without user or API impact label Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (8a7df00) to head (1e43e88).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #971   +/-   ##
=========================================
  Coverage     88.96%   88.96%           
  Complexity      180      180           
=========================================
  Files            11       11           
  Lines           716      716           
  Branches         92       92           
=========================================
  Hits            637      637           
  Misses           62       62           
  Partials         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

☀️ Quality Monitor

  • 🚦 Tests: 95 tests passed, 2 skipped
  • 👣 Code Coverage: 91% coverage achieved
  • 🔬 Mutation Coverage: 80% mutations killed
  • ⚠️ Style: 95 warnings found (0 error, 0 high, 95 normal, 0 low)
  • 🐛 Bugs: No warnings found

More details are available in the GitHub Checks Result.

@uhafner uhafner merged commit 052d2be into main Mar 30, 2024
17 checks passed
@uhafner uhafner deleted the ignore-parameters-for-override branch March 30, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant