Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation #13

Merged
merged 19 commits into from
Jan 18, 2024
Merged

API documentation #13

merged 19 commits into from
Jan 18, 2024

Conversation

rtxm
Copy link
Contributor

@rtxm rtxm commented Jan 5, 2024

See Netlify preview.

Copy link

This pull request has been linked to Shortcut Story #28389: The Python SDK documentation should be easily accessible.

@rtxm rtxm force-pushed the feature/sc-28389/documentation branch from 2cbe418 to d49d8a2 Compare January 5, 2024 18:33
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for python-uhlive-sdk ready!

Name Link
🔨 Latest commit e6f626c
🔍 Latest deploy log https://app.netlify.com/sites/python-uhlive-sdk/deploys/659d6154b9fa290008263c31
😎 Deploy Preview https://deploy-preview-13--python-uhlive-sdk.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rtxm rtxm changed the title Feature/sc 28389/documentation API documentation Jan 9, 2024
@rtxm rtxm marked this pull request as ready for review January 9, 2024 11:51
@rtxm rtxm requested review from merwan and shostelet January 9, 2024 11:52
@@ -3,14 +3,20 @@
The Uh!live Python SDK provides convenient access to the Uh!live API from
applications written in the Python language.

Read the [documentation for the Conversation API](https://docs.allo-media.net/live-api/) and [for the Recognition API (vocal bot toolkit)](https://docs.allo-media.net/stream-api-bots/).
Read the [full documentation](https://python-uhlive-sdk.netlify.app/).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I can't access this website

Copy link
Contributor Author

@rtxm rtxm Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're just reviewing it as a netlify preview before deployment 😉 but I already put the definitive link in anticipation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a DNS entry for this documentation. Something like https://docs.uh.live/sdk/python.
@shostelet I let you think about a proper structure for the URL

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I was not yet fully awake 😅
https://docs.uh.live/sdk/python suits me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be a subdomain to work with Netlify, not a path @merwan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like python-sdk-docs.uh.live ou python-sdk.uh.live

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# user_password = "…"

auth_url, auth_params = build_authentication_request(uhlive_client, uhlive_secret)
# or auth_url, auth_params = build_authentication_request(uhlive_client, user_id=user_id, user_pwd=user_password)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the old auth way? shouldn't we get rid of it as it is deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why old? I'm not aware of any deprecation of letting users connect through a client in Keycloak. Did we abandon this way?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both line 30 and 31 are KC connection? If so, ignore my comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both are KC connections indeed.

Copy link
Contributor

@merwan merwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not read the whole documentation, but this seems very complete, thanks!

@rtxm rtxm merged commit 4dee9c2 into main Jan 18, 2024
7 checks passed
@rtxm rtxm deleted the feature/sc-28389/documentation branch January 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants