Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show] session_id #18

Merged
merged 4 commits into from
Mar 15, 2024
Merged

[show] session_id #18

merged 4 commits into from
Mar 15, 2024

Conversation

rtxm
Copy link
Contributor

@rtxm rtxm commented Mar 14, 2024

No description provided.

Copy link

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for python-uhlive-sdk ready!

Name Link
🔨 Latest commit 870bfff
🔍 Latest deploy log https://app.netlify.com/sites/python-uhlive-sdk/deploys/65f3326e8ee07500088db39b
😎 Deploy Preview https://deploy-preview-18--python-uhlive-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rtxm rtxm changed the title session_id [show] session_id Mar 14, 2024
@rtxm rtxm requested review from merwan and Julianuuus March 14, 2024 17:25
Copy link
Contributor

@merwan merwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client.set_params(
speech_language="fr",
no_input_timeout=5000,
logging_tag="basic_async_test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this logging_tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between session-id and logging-tag is that the former is for the complete session and the latter is used to tag a contiguous sequence of interactions within the session.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations

@rtxm rtxm merged commit d746f62 into main Mar 15, 2024
7 checks passed
@rtxm rtxm deleted the feature/sc-46892/session-id branch March 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants