Add better type definitions for Promise onrejected #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

uinz wants to merge 1 commit into uhyo:master from uinz:better-promise-onrejected

uinz commented Jun 15, 2023

Made a few changes:

promise.catch is not allowed to accept null undefined and is not optional
The final type is the union type of onfulfilled and onrejected


          Add better type definitions for Promise onrejected

cfd698e

Author

uinz commented Jun 15, 2023

Oh, wait. I found out that things were worse than I thought

The following code is actually legal.

Close first, I need to research

uinz closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet