import 'angular' line should be removed

[arslan2012]

As stated in Angular-cli docs
if AngularJS was added through scripts tag in angular-cli.json, then
import * as angular from 'angular'; shouldn't be used, or else angular will get call twice and get bundled twice even in production mode.

[wiltzius]

I was chasing down why we have 2 copies of angular in our builds now and traced it to this. We have our legacy Angular 1 application, which puts angular in global scope, and then we have our newer Angular 2 stuff using angular-hybrid.

How can we avoid having two copies of it?

[wiltzius]

I found (I think) a workaround, maybe this will help someone:

use https://webpack.js.org/configuration/externals/ to mark 'angular' as something that shouldn't be bundled (we're loading it separately). No longer in the output bundle!

[arslan2012]

i think angular-hybrid intents for user to use angular as a dynamic module. they didn't consider angular in global scope. I don't blame them tho, because detecting global then importing is kinda hard to do right now

[wiltzius]

I'm not sure what the intent was, but I do notice that in this repo the example uses angular as an 'external' in its webpack config:

https://github.com/ui-router/angular-hybrid/blob/master/example/webpack.config.js#L28

I had missed that earlier!

[arslan2012]

I'm not sure what the intent was, but I do notice that in this repo the example uses angular as an 'external' in its webpack config:

https://github.com/ui-router/angular-hybrid/blob/master/example/webpack.config.js#L28

I had missed that earlier!

because this bug only appears in ng build

[christopherthielen]

Hopefully this is fixed in 7.0.0, please let me know if you have problems!