Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"href" "params" parameter should be optional #287

Closed
ivanvoznyakovsky opened this issue Jan 7, 2019 · 0 comments · May be fixed by Matthelonianxl/lisk-explorer#1, maxiplux/mum.cs425.project#5 or maxiplux/mum.cs425.project#7

Comments

@ivanvoznyakovsky
Copy link

href(stateOrName: StateOrName, params: RawParams, options?: HrefOptions): string {
const defaultHrefOpts = {
lossy: true,
inherit: true,
absolute: false,
relative: this.$current,
};
options = defaults(options, defaultHrefOpts);
params = params || {};

params anyway default to an empty object but is required in href signature. this forces to always pass at least an empty object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment