Move @uirouter/angularjs and @uirouter/react to peerDependencies #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2017 22:02
…er dependencies Since @uirouter/core is stateful, having a different version of @uirouter/angularjs or @uirouter/react in the user project would cause some very hard to debug issues. Moving them to peer dependencies instead forces the versions to be the same. Also, the interfaces to the core API are now safely available in the user project. Fixes ui-router#4.
|
@alexgerv thanks for the PR! I'm happy other people are getting use out of this project. The way the hybrid project is supposed to work is that you replace I'm not keen to move these to peer dependencies because I don't want users to have to explicitly depend on specific versions of multiple packages. Because of this, I'm probably going to close this PR. However, I'd like to understand how the dependencies currently in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
@uirouter/coreis stateful, having a different version of@uirouter/angularjsor@uirouter/reactin the user project would cause some very hard to debug issues. Moving them to peer dependencies instead forces the versions to be the same. Also, the interfaces to the core API are now safely available in the user project.Fixes #4.