fix(ui5-tooling-transpile): add support for d.ts source maps #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
d.ts.map
support to allow to "Go to Sources Definition" in VSCode. We need to post-process thed.ts.map
to correct the source mapping to the sources of the project. Due to the virtual paths, this doesn't work automatically.With this fix, we are in general switching back to using
types
in thetsconfig.json
. ThetypeRoots
seem to work semi-optimal in case of using dependencies as thetypeRoots
are scanning the given folder and its subfolders forindex.d.ts
files. Usingtypes
the NPM package needs to provide thetypes
mapping to theindex.d.ts
file in thepackage.json
but in general we do not run into theTS2688
issue when running type checking. With the solution usingtypes
all scenarios are working fine now. Once a custom type is being added it requires to list theopenui5
and the custom types of the library next to it.