Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag-and-drop functionality for wdi5 #238

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ph-alsvik
Copy link
Contributor

Hello again, JS-Soft!

This is my "first take" on drag-and-drop functionality for wdi5. sorry for the delay, it's been busy at the office lately.
Let me know what you think, and what ought to be changed.

Also working on test script for this aswell, which is coming up soon.

@vobu vobu added the enhancement New feature or request label Apr 20, 2022
@dominikfeininger
Copy link
Collaborator

Hi, nice approach. What about the wdio https://webdriver.io/docs/api/element/dragAndDrop/ function?

@ph-alsvik
Copy link
Contributor Author

Honestly, I tried doing drag-and-drop via wdio api, but couldn't get it to work. I managed to grap the element, but it wouldn't drop it on the target, for some reason. Rather than trying to make it work, I decided to use the sap.ui.test.actions library, and it worked.

That being said, very curious to hear the pros and cons of my approach vs one using wdio api 😃

@dominikfeininger
Copy link
Collaborator

Hi, I also tried to get the wdio dragAndDrop to work -> no success see webdriverio/webdriverio#4134

At least I added a testcase for you

@vobu
Copy link
Contributor

vobu commented Apr 25, 2022

That being said, very curious to hear the pros and cons of my approach vs one using wdio api

I'm most definitely pro using the UI5 API for enabling drag'n'drop testing.
WebdriverIO's dragAndDrop highly depends on a WebApp's implementation of the UX pattern anyway - so we're better of going the UI5-API-route!

@vobu
Copy link
Contributor

vobu commented Jun 7, 2022

hey @ph-alsvik, anything we can help with at that point to get the drag-and-drop support further off the ground?

@ph-alsvik
Copy link
Contributor Author

Hi @vobu Sorry it's been quiet on my part lately! It's been very busy at the office these past weeks. I'll have more time to look into it next week.

@vobu
Copy link
Contributor

vobu commented Jun 8, 2022

no worries! just wanted to chime in and hear where things are at. Really appreciate the effort you're putting in here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo 🗓
Development

Successfully merging this pull request may close these issues.

4 participants