Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (useCopyToClipboard): copyToClipboard should return promise #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kendrickw
Copy link

@kendrickw kendrickw commented Jun 20, 2024

Fixes #312

The copyToClipboard function is not returning a promise currently. The intention (at least according to the function signature) is to fulfill the promise when the text is copied:

usehooks/index.d.ts

Lines 126 to 129 in 90fbbb4

export function useCopyToClipboard(): [
string | null,
(value: string) => Promise<void>
];

This PR will change the code to return a promise. So the promise can fulfill when the text is copied successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useCopyToClipboard: copy method not returning promise
1 participant