protoc: simplify recipe #1

madebr · 2020-03-06T12:58:22Z

Apart from a warning about cmake modules, this builds on Windows.

[HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: ['./lib/cmake/protoc/'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)
[HOOK - conan-center.py] post_package_info(): ERROR: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files:
./lib/cmake/protoc/protoc-generate.cmake
./lib/cmake/protoc/protoc-module.cmake
./lib/cmake/protoc/protoc-options.cmake (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H019)

zyre: add shared/static + do not override shared in options

recipes/protoc/3.9.x/conanfile.py

uilianries · 2020-03-10T13:00:47Z

recipes/protoc/3.9.x/conanfile.py

@@ -26,6 +28,10 @@ def _build_subfolder(self):
    def _cmake_base_path(self):
        return os.path.join("lib", "cmake", "protoc")

+    def configure(self):
+        if self.settings.os_build != self.settings.os and self.settings.arch_build != self.settings.arch:


Nope, we need to support it.

The new crossbuilding pr by jsgogo will fix this.
(so this recipe should be modified again to use arch and os instead of arch_build and os_build)

So let's wait with this pr until that pr lands?
Because that might take some time.

well, we can push it forward, and update once that feature is available.

Ok. Can you review and merge it?
(and maybe rebase on top of CCI's master since this branch is quite old)

uilianries · 2020-03-10T13:01:27Z

recipes/protoc/3.9.x/conanfile.py

            os.path.join(self._cmake_base_path, "protoc-module.cmake"),
            os.path.join(self._cmake_base_path, "protoc-options.cmake"),
-            os.path.join(self._cmake_base_path, "protoc-targets.cmake"),
-            os.path.join(self._cmake_base_path, "protoc-targets-noconfig.cmake")
+            os.path.join(self._cmake_base_path, "protoc-generate.cmake"),


what is that protoc-generate.cmake ?

It's protobuf-config.cmake renamed and with all package finding stuff disabled.

sounds pretty interesting :D

I named it generate because it contains the protobuf_generate_cpp functions.

recipes/protoc/3.9.x/test_package/CMakeLists.txt

Use external patch for geos

jwt-cpp: test_package needs cmake generator

Adapt for Conan Center Index

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Simplify dwg2dxf

Prepare for CCI

google-guetzli: set correct cflags (for other archs) + lint code

Fix mirror list

Simplify quickfix recipe

Build simdjson 0.4.7 on Linux

volk: use fixed commit hash

Update cmake version to cbor

Improve libuvc

elfutils: patch automake scripts to fix static + simplify Werror patch

* Add ignition-math * Formatting * Change version_mejor approach * Address review comments * Add import ConanInvalidConfiguration * del fPIC in Windows * Add shared and static support * Add import glob * Unconditially remove files * Address review comments * Remove fPIC option since it's always true * Change test_package.cpp * Change test CMakeLists * Add regex patch * Add friends function Angle definition patch * Revert "Add friends function Angle definition patch" This reverts commit 4e68918. * Explicitly link libc++ * Revert "Explicitly link libc++" This reverts commit f659367. * Don't run git clone + support fPIC + create components (#1) * Add cmake_wrapper * Update recipes/ignition-math/all/CMakeLists.txt Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> * ignition-math: use ignition-cmake (#2) * bump to 6.7.0 * bump 6.7.0 * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * remove pkgconf * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Juan Oxoby <me@jmoxo.by> Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Co-authored-by: Juan Oxoby <49600381+joxoby@users.noreply.github.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

@madebr

* Initial support for wasmtime package * Fixed build package on Linux * Updates according the comments in review #0 * Update recipes/wasmtime/all/conanfile.py Update license type Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Updates according the comments in review #1 * Updates according the comments in review #2 * Updates according the comments in review #3 * Updates according the comments in review #4 * Updates according the comments in review #5 * Next iteration of fixes * Fixed cmake variable C_STANDARD -> CMAKE_C_STANDARD * Added check on minimal version of conan * Used copytree instead of copy individual files * Fixed the build * Added checking for architechure in validate(...) * Updated receipt for new comments from @madebr * Fixed calling method tools.cross_building(...) * Update def package(self) according the comments in review * Updated versions of wasmtime * Updated forgot version ugrade * Fixed sha256sum for macos * Fixed SHA256 for Linux * Updated all SHA256 to proer values Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Improve openE57

* wip patch for Visual Studio 2019 * Conan v2 compat * Conan v2 compat * rollback to v1 code * rollback to v1 code * self.copy replacement * fix * fix * wip * wip * wip * wip * wip * wip * wip * fixed paths * adds support for vc17 * Use new Conan tools (#1) * Use new Conan tools Signed-off-by: Uilian Ries <uilianries@gmail.com> * Fix is_msvc Signed-off-by: Uilian Ries <uilianries@gmail.com> Signed-off-by: Uilian Ries <uilianries@gmail.com> * Update recipes/mpir/all/conanfile.py * Fix license source path Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

Adapt new Tools

B64 - use cmake and new repo

Improve conan-io#16569

* Add `loguru/2.1.0` recipe Loguru: a lightweight and flexible C++ logging library. Website: https://emilk.github.io/loguru/index.html Source code: https://github.com/emilk/loguru Closes conan-io#14542 * Simplify CMake and native features usage (#1) Simplifications and Conan v2 fixes * Update recipes/loguru/all/conanfile.py * Update recipes/loguru/all/conanfile.py * Update recipes/loguru/all/conanfile.py * loguru: use latest commit with CMake support * fixup: missing comma * fixup: typo * chore: rm config files * fixup: clean up defines * add includedirs, simplify test_package * add suffix * add m * fix windows shared * remove pdbs --------- Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: czoido <mrgalleta@gmail.com>

libqasm

protoc: simplify recipe

33a050a

madebr mentioned this pull request Mar 7, 2020

Add Protobuf protoc 3.9.1 conan-io/conan-center-index#65

Closed

4 tasks

uilianries pushed a commit that referenced this pull request Mar 9, 2020

Merge pull request #1 from madebr/zyre_for_casabre

8b2a0ac

zyre: add shared/static + do not override shared in options

uilianries reviewed Mar 9, 2020

View reviewed changes

recipes/protoc/3.9.x/conanfile.py Outdated Show resolved Hide resolved

protoc: disallow cross building

59aa6a8

uilianries reviewed Mar 10, 2020

View reviewed changes

madebr added 3 commits March 10, 2020 16:39

protoc: remove configure

ecb4af3

protoc: do not build and test when cross building

75c0881

protoc: remove arch and os from settings

248c077

uilianries reviewed Mar 12, 2020

View reviewed changes

recipes/protoc/3.9.x/test_package/CMakeLists.txt Show resolved Hide resolved

uilianries merged commit 92058e2 into uilianries:feature/protoc Mar 12, 2020

madebr deleted the pr_protoc branch March 12, 2020 16:57

uilianries pushed a commit that referenced this pull request Mar 17, 2020

Merge pull request #1 from uilianries/add-geos-3.8.0

e5bcc61

Use external patch for geos

uilianries pushed a commit that referenced this pull request Mar 26, 2020

Merge pull request #1 from madebr/jwt-cpp-prince-chrismc

1721284

jwt-cpp: test_package needs cmake generator

uilianries pushed a commit that referenced this pull request May 1, 2020

Merge pull request #1 from uilianries/feature/cppcodec

6b16ad7

Adapt for Conan Center Index

uilianries added a commit that referenced this pull request May 1, 2020

FreeBSD support for libsodium (#1)

964cbfe

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries pushed a commit that referenced this pull request May 6, 2020

Merge pull request #1 from uilianries/libdxfrw

87384df

Simplify dwg2dxf

uilianries pushed a commit that referenced this pull request Jun 9, 2020

Merge pull request #1 from uilianries/oatpp

657082c

Prepare for CCI

uilianries pushed a commit that referenced this pull request Jun 19, 2020

Merge pull request #1 from madebr/pull_1561

e272583

google-guetzli: set correct cflags (for other archs) + lint code

uilianries pushed a commit that referenced this pull request Jun 19, 2020

Merge pull request #1 from uilianries/zlib_iosaware

9d6ba07

Fix mirror list

uilianries pushed a commit that referenced this pull request Jun 19, 2020

Merge pull request #1 from uilianries/quickfix

ea586cc

Simplify quickfix recipe

uilianries pushed a commit that referenced this pull request Jul 23, 2020

Merge pull request #1 from uilianries/simdjson-0.4.7

c0d040c

Build simdjson 0.4.7 on Linux

uilianries pushed a commit that referenced this pull request Aug 3, 2020

Merge pull request #1 from madebr/pr_volk

7d67d6c

volk: use fixed commit hash

uilianries pushed a commit that referenced this pull request Aug 18, 2020

Merge pull request #1 from uilianries/libcbor/custom_alloc

731b3a2

Update cmake version to cbor

uilianries pushed a commit that referenced this pull request Aug 19, 2020

Merge pull request #1 from uilianries/libuvc

97aa046

Improve libuvc

uilianries pushed a commit that referenced this pull request Aug 29, 2020

Merge pull request #1 from madebr/pr_elfutils

706481f

elfutils: patch automake scripts to fix static + simplify Werror patch

uilianries pushed a commit that referenced this pull request Jul 14, 2021

Updates according the comments in review #1

43445ea

uilianries pushed a commit that referenced this pull request Feb 16, 2022

Merge pull request #1 from uilianries/openE57

b1177f8

Improve openE57

uilianries pushed a commit that referenced this pull request Sep 12, 2022

Merge pull request #1 from uilianries/update-libgc-8_2_2

ff57f8c

Adapt new Tools

uilianries pushed a commit that referenced this pull request Apr 19, 2023

Merge pull request #1 from uilianries/b64-2.0.0.1

4e767cd

B64 - use cmake and new repo

uilianries pushed a commit that referenced this pull request May 11, 2023

Merge pull request #1 from uilianries/port-zbar-conan2

f8088d0

Improve conan-io#16569

uilianries pushed a commit that referenced this pull request Feb 29, 2024

Merge pull request #1 from rturrado/libqasm

1dae883

libqasm

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

protoc: simplify recipe #1

protoc: simplify recipe #1

madebr commented Mar 6, 2020

uilianries Mar 10, 2020

madebr Mar 10, 2020 •

edited

Loading

uilianries Mar 10, 2020

madebr Mar 11, 2020

uilianries Mar 11, 2020

madebr Mar 12, 2020

uilianries Mar 10, 2020

madebr Mar 10, 2020 •

edited

Loading

uilianries Mar 10, 2020

madebr Mar 12, 2020

protoc: simplify recipe #1

protoc: simplify recipe #1

Conversation

madebr commented Mar 6, 2020

Choose a reason for hiding this comment

madebr Mar 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madebr Mar 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madebr Mar 10, 2020 •

edited

Loading

madebr Mar 10, 2020 •

edited

Loading