Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sixel encoding #557

Merged
merged 2 commits into from
Sep 28, 2024
Merged

added sixel encoding #557

merged 2 commits into from
Sep 28, 2024

Conversation

BaerLKR
Copy link
Contributor

@BaerLKR BaerLKR commented Sep 28, 2024

This is in regards to this #38 issue, as suggested i used icy_sixel

It encodes to sixel if it finds sixel in the TERM environment variable. That sadly isn't always the case but I couldn't find another way to detect if a terminal supports sixel. And I wanted to prevent false-positive sixel output because if you don't know what it is this string of random chars is rather confusing. So there will be quite a few false-negatives but there is still the half block fallback from viuer

I hope this is what y'all had in mind and I am looking forward to your criticism

@kaikalii
Copy link
Member

kaikalii commented Sep 28, 2024

I think you need to use option_env!

@BaerLKR
Copy link
Contributor Author

BaerLKR commented Sep 28, 2024

yeah i just noticed too
will fix in just a second

@BaerLKR
Copy link
Contributor Author

BaerLKR commented Sep 28, 2024

I think you need to use option_env!

I think I need to use std::env::var because it is a runtime check

@kaikalii kaikalii merged commit f0ae7cc into uiua-lang:main Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants