fix(Polyline): fix component uninstall issue. (#326)

uiwjs · Aug 22, 2023 · f465936 · f465936
1 parent b829e56
commit f465936
Showing 1 changed file with 13 additions and 13 deletions.
diff --git a/packages/polyline/src/usePolyline.tsx b/packages/polyline/src/usePolyline.tsx
@@ -11,22 +11,22 @@ export function usePolyline(props = {} as UsePolyline) {
   const { map } = useMapContext();
   useEffect(() => {
     if (map && !polyline) {
-      let instance: AMap.Polyline = new AMap.Polyline(other);
+      const instance: AMap.Polyline = new AMap.Polyline(other);
       map.add(instance);
       setPolyline(instance);
-      return () => {
-        if (instance) {
-          if (AMap.v) {
-            map && map.remove(instance);
-          } else {
-            // 暂不使用这个 API，这个不兼容 v1.4.xx，改用 map.remove API
-            map && map.removeLayer(instance);
-          }
-          setPolyline(undefined);
-        }
-      };
     }
-  }, [map]);
+    return () => {
+      if (polyline) {
+        if (AMap.v) {
+          map && map.remove(polyline);
+        } else {
+          // 暂不使用这个 API，这个不兼容 v1.4.xx，改用 map.remove API
+          map && map.removeLayer(polyline);
+        }
+        setPolyline(undefined);
+      }
+    };
+  }, [map, polyline]);
 
   useEffect(() => {
     if (polyline) {