Marker flashed in the wrong position

[martesi]

Marker and Text are showed by useVisible before their positions are set to the correct ones by useSettingProperties.

In v7.0.2, this causes flashes.

[martesi]

#370 was assuming problem is caused by the display timing. But the marker is created with same params, it should has the right position in the first place. I can force visible to false on create and set default value for visiable, so useVisiable can display the correct position marker. It's not solving the mystery of the initial wrong position though.

[jaywcjlove]

@martesi Can rolling back the code fix this issue? I always believed there was nothing wrong with the previous one.

[martesi]

You mean v7.0.1? I have pinned the version to v7.0.0 so far. v7.0.1 works fine without strict mode, but I personally like to keep it open, as the reason react recommended it. If that's decided, I can opt out strict mode and provide feedback based on that.

[martesi]

This is actually my own fault.

As mentioned earlier, the initial props are passed to Marker constructor on create. In this scenario, Marker should be placed at the right position in the first place.

In this case however, I used a signal that will trigger a effect to update position state. Instead of relying on the position state, I used the signal to control Marker rendering. So the marker is rendered with position undefined then the actual position.

I suppose the old implementation of usePortal might cause the Marker content be rendered later, so the sudden change is not noticed before.

Thank you @jaywcjlove for patient replies and quick responses.

Since the new implementation is now not involved with createRoot, maybe it's safe to say we still support older react versions?

BTW, visiable seems to be a typo. From what I see in the code, react-amap takes visiable as the valid option and modify the visibility on effect. Unless user specify visible at the same time, the related overlays will created as visible by default. Maybe we can mark the typo as deprecated and adjust the behavior accordingly?

[jaywcjlove]

visiable -> visible It's a big job.