Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perhaps its not a good idea to trigger 'registerCompletionItemProvider' with 'value' #161

Closed
PisecesPeng opened this issue Aug 16, 2022 · 1 comment
Closed

Perhaps its not a good idea to trigger 'registerCompletionItemProvider' with 'value' #161

PisecesPeng opened this issue Aug 16, 2022 · 1 comment

Comments

@PisecesPeng
Copy link
Contributor

https://github.com/jaywcjlove/react-monacoeditor/blob/c83f9b2ed3adcb96aa9a4e4eadd05c0b9c92f96c/src/index.tsx#L136

大佬好,
感觉使用value去触发monaco.languages.registerCompletionItemProvider不是一个特别好的时机.
是不是可以调整下？

也许是我没有理解其中封装的逻辑.
Best regards!
@PisecesPeng PisecesPeng mentioned this issue Aug 16, 2022
Merged
jaywcjlove added a commit that referenced this issue Aug 16, 2022
@jaywcjlove
fix: Fix the error the variable CPDisposable does not exist. (#162 #…
7e0fd05 
…161)
github-actions bot pushed a commit that referenced this issue Aug 16, 2022
@jaywcjlove
v3.5.4 fix: Fix the error the variable CPDisposable does not exist. (…
3c9dd89 
…#162 #161) 7e0fd05
jaywcjlove added a commit that referenced this issue Aug 16, 2022
@jaywcjlove
released v3.5.4 (#162 #161)
edee526
@jaywcjlove
Copy link
Member

@PisecesPeng 优化非常好 👍 , 就是有点小瑕疵，我给修复了一下

Upgrade v3.5.5

github-actions bot pushed a commit that referenced this issue Aug 16, 2022
@jaywcjlove
v3.5.5 released v3.5.4 (#162 #161) edee526
434caac
jaywcjlove added a commit that referenced this issue Aug 20, 2022
@jaywcjlove
fix: Fix value issue. (#162 #161)
3d26f6d
jaywcjlove added a commit that referenced this issue Aug 20, 2022
@jaywcjlove
released v3.5.6 (#162 #161)
178a34f
github-actions bot pushed a commit that referenced this issue Aug 20, 2022
@jaywcjlove
v3.5.6 released v3.5.6 (#162 #161) 178a34f
8c93912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaywcjlove @PisecesPeng