improve error message for join in with query

ujjwalguptaofficial · Nov 26, 2024 · 7d9b871 · 7d9b871
1 parent ed7e545
commit 7d9b871
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/worker/executors/select/join.ts b/src/worker/executors/select/join.ts
@@ -348,7 +348,7 @@ class Join {
         // check on info & with info 
         if (qry.with !== table2.table) {
             err = new LogHelper(ERROR_TYPE.InvalidJoinQuery,
-                `on value should contains value of with`
+                `The 'on' condition must reference a column from the table specified in 'with'. Found '${qry.on}', but '${qry.with}' was provided in 'with'.`
             );
         }
 

diff --git a/test/cases/select/join.js b/test/cases/select/join.js
@@ -661,7 +661,7 @@ describe('Test join', function () {
         }).catch(function (err) {
 
             var error = {
-                "message": "on value should contains value of with",
+                "message": "The 'on' condition must reference a column from the table specified in 'with'. Found 'Orders.customerId=Customers.customerId', but 'invalid_table' was provided in 'with'.",
                 "type": "invalid_join_query"
             }
             expect(err).to.eql(error);
@@ -915,4 +915,4 @@ describe('Test join', function () {
         }).catch(done);
     })
 
-});
+});