Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving to new CQ export method #707

Closed
wants to merge 5 commits into from
Closed

moving to new CQ export method #707

wants to merge 5 commits into from

Conversation

shimwell
Copy link
Collaborator

@shimwell shimwell commented Feb 2, 2021

Proposed changes

This removes the opening of a file and use of exporters.exportShape and replaces it with exporters.export as discussed in #82

The former is now depreciated.

The new option will also support additional SVG options via an opt keyword once CQ 2.1 is released

Also slightly more control over the stl export is also offered via the introduction of a new argument called angular_tolerance

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the title updated precision exportShape to export moving to new CQ export method Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #707 (39b92d1) into develop (d194655) will decrease coverage by 2.54%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #707      +/-   ##
===========================================
- Coverage    98.86%   96.32%   -2.55%     
===========================================
  Files           68       69       +1     
  Lines         4325     4436     +111     
===========================================
- Hits          4276     4273       -3     
- Misses          49      163     +114     
Impacted Files Coverage Δ
...tric_neutronics/make_faceteted_neutronics_model.py 0.00% <0.00%> (ø)
paramak/reactor.py 99.14% <100.00%> (-0.01%) ⬇️
paramak/shape.py 99.45% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d194655...39b92d1. Read the comment docs.

Copy link

@billingsley-john billingsley-john left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice addition to make things more tidy!

@shimwell
Copy link
Collaborator Author

shimwell commented Feb 4, 2021

Not sure why this is failing, I've tried switching back to the original stl export and changing pymoab to the main branch but the github actions CI are still failing

@shimwell
Copy link
Collaborator Author

shimwell commented Feb 8, 2021

I need to redo parts of this PR as #718 has updated the svg export

@shimwell shimwell marked this pull request as draft February 8, 2021 18:18
@shimwell shimwell changed the base branch from develop to develop_combine2 February 8, 2021 18:33
Base automatically changed from develop_combine2 to develop February 8, 2021 18:40
@shimwell
Copy link
Collaborator Author

shimwell commented Feb 8, 2021

closing this a #720 #718 and #721 have added the features

@shimwell shimwell closed this Feb 8, 2021
@shimwell shimwell deleted the imporoved_exports branch February 8, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants