-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving to new CQ export method #707
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #707 +/- ##
===========================================
- Coverage 98.86% 96.32% -2.55%
===========================================
Files 68 69 +1
Lines 4325 4436 +111
===========================================
- Hits 4276 4273 -3
- Misses 49 163 +114
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice addition to make things more tidy!
Not sure why this is failing, I've tried switching back to the original stl export and changing pymoab to the main branch but the github actions CI are still failing |
I need to redo parts of this PR as #718 has updated the svg export |
Proposed changes
This removes the opening of a file and use of exporters.exportShape and replaces it with exporters.export as discussed in #82
The former is now depreciated.
The new option will also support additional SVG options via an opt keyword once CQ 2.1 is released
Also slightly more control over the stl export is also offered via the introduction of a new argument called
angular_tolerance
Types of changes
Checklist