Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subtitles] add a download button for sidecar subtitles #181

Closed
OttoKerner opened this issue May 19, 2016 · 10 comments
Closed

[subtitles] add a download button for sidecar subtitles #181

OttoKerner opened this issue May 19, 2016 · 10 comments

Comments

@OttoKerner
Copy link

OttoKerner commented May 19, 2016

Please add the possibility to download sidecar subtitles.
Reasoning: Automatically downloaded subtitles are hidden in the obfuscated mess that is the plex data folder. For a normal user to find the right subtitle file in here is next to impossible (or at least very tedious).

If you now try to get ahold of this subtitle file to edit it or to move it beside the video file on your laptop you use in the countryside where there is not internet, you have a hard time.

Maybe, in stage 2, you could opt to move the file automatically beside the video file and, after checking it was successfully copied ;-) remove it from the Plex data folder.
Some users may prefer this method.

@ukdtom
Copy link
Owner

ukdtom commented May 19, 2016

But if we move it, agent will re-download it again, so that part will not work, or?

@OttoKerner
Copy link
Author

OttoKerner commented May 19, 2016

But if we move it, agent will re-download it again, so that part will not work, or?

As I understand it, the agent will only re-download subtitles if the movie is refreshed. I may be wrong though.
But even if so, the first option is still very desirable.

@ukdtom ukdtom added this to the V3.0 milestone May 19, 2016
@ukdtom
Copy link
Owner

ukdtom commented May 19, 2016

We need to make a download button for both agent based and sidecars.
First we need to make a backend function for this :-(

@ukdtom ukdtom assigned ukdtom and unassigned dagalufh May 19, 2016
ukdtom added a commit that referenced this issue Jun 26, 2016
@ukdtom
Copy link
Owner

ukdtom commented Jun 26, 2016

Framework updated with c6d1712

See the doc under "Download Subtitle"

@ukdtom ukdtom assigned dagalufh and unassigned ukdtom Jun 26, 2016
@ukdtom ukdtom modified the milestones: V2.4, V3.0 Oct 22, 2016
@ukdtom ukdtom assigned creoludifico and unassigned dagalufh Jan 21, 2017
@creoludifico
Copy link
Collaborator

Ready for test.
Only sidecars subtitles are possible to download.

3047812

@ukdtom
Copy link
Owner

ukdtom commented Jan 22, 2017

Tested okay by me.

@OttoKerner What you had in mind here?

Ohhh....and while at it, please also look into #243

Download my work branch for a test
https://github.com/ukdtom/WebTools.bundle/archive/tommy-work.zip

@ukdtom
Copy link
Owner

ukdtom commented Jan 22, 2017

@creoludifico Please see comments for #245

Sorry

creoludifico added a commit that referenced this issue Jan 22, 2017
Both Sidecar and Agent is now possible to down
@creoludifico
Copy link
Collaborator

Now possible to download if it's agent sub

@OttoKerner
Copy link
Author

Download is working for me. 👍
Page navigation as well.

@ukdtom
Copy link
Owner

ukdtom commented Jan 25, 2017

Thanks Otto

@ukdtom ukdtom closed this as completed Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants