allow specification of a index template #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerickson
force-pushed
the
specify_index_template
branch
from
5fa9a87 to
32f301e
Compare
|
@pitr Do you have any comments? I'd love to get this merged. Thanks! |
| raise "If you specify a template_name you must specify a valid template file (checked '#{@template_file}')!" | ||
| end | ||
| file_contents = IO.read(@template_file).gsub(/\n/,'') | ||
| template = JSON.parse(file_contents) |
There was a problem hiding this comment.
simply leaving last line as JSON.parse(file_contents) is sufficient
|
Looks good, I left a few comments. Could you also extract all template logic to a separate module. |
aerickson
force-pushed
the
specify_index_template
branch
from
32f301e to
19d734b
Compare
|
@pitr Thanks for the feedback. Changes made. I was rescuing the more specific exception earlier when I was testing, but I encountered an error about an undeclared exception class when fluent-plugin-aws-elasticsearch-service consumed fluent-plugin-elasticsearch... but that seems to be gone now (just tested). Not sure what changed. :) |
|
1.7.0 released with this change. Also, I renamed template code in e87598a since out_*.rb files are for plugins |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify a template to define on connection creation (similar to logstash).
See #33.
versionin gemspec are untouchedelasticsearch_dynamic(not required but recommended)