Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Backwards Incompatible Config Additions #56

Closed
phily245 opened this issue May 19, 2021 · 1 comment
Closed

Fix Backwards Incompatible Config Additions #56

phily245 opened this issue May 19, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@phily245
Copy link
Contributor

What is the issue?

In https://github.com/ukfast/laravel-health-check/pull/53/files, new config values were added without a fallback.
This was a breaking change for those who have a custom config file, as the new config now returns null, so the paths change from /health and /ping to both be /.

Steps To Reproduce

  • Update a laravel/lumen application with an existing custom config file to the latest version
  • Hit /ping and /health
  • Both get 404 responses

Expected behaviour

200 responses to /ping and /health instead of 404s

Possible fixes

Add a fallback to the config values

Additional context

N/a

@phily245 phily245 added the bug Something isn't working label May 19, 2021
@tylerwoonton
Copy link
Contributor

Thanks for this. Let me know if you need anything else, @phily245!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants