NTBS-1768 Update old NPM packages #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshCadney
suggested changes
Feb 17, 2021
JoshCadney
approved these changes
Feb 18, 2021
Remove aspnet webpack to make way for .NET 5 upgrade, and hot module reloading of the site, which is much more difficult in .NET 5. See this issue for a discussion of the .NET changes that lead to this dotnet/aspnetcore#12890 Update webpack from verion 4 to 5. This required changing how GOV.UK assets are made accessible, they are now included using the CopyPlugin.
benjimarshall
force-pushed
the
NTBS-1768-npm-updates
branch
from
19125c4
to
dbb2684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove aspnet webpack to make way for .NET 5 upgrade, and hot module
reloading of the site, which is much more difficult in .NET 5. See
this issue for a discussion of the .NET changes that lead to this
Update webpack from verion 4 to 5. This required changing how GOV.UK
assets are made accessible, they are now included using the CopyPlugin.
Checklist: