Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wind-sea and swell partitioned spectral updates to ww3_uprstr #1

Merged
merged 5 commits into from
Nov 6, 2019

Conversation

ukmo-ansaulter
Copy link

Feature branch fb_uprstr_seaswell adds Lionello/Toba based spectral updates and uses either text file or restart file (WRST switch) based wind inputs alongside SWH and wave spectra

Changes relate to WAVEWATCH III issue #30

@ukmo-ccbunney ukmo-ccbunney changed the base branch from develop to master November 4, 2019 10:55
@ukmo-ccbunney ukmo-ccbunney changed the base branch from master to develop November 4, 2019 10:55
Copy link
Member

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me - just a few comments in ww3_upstrt.ftn need addressing.

model/ftn/ww3_uprstr.ftn Show resolved Hide resolved
model/ftn/ww3_uprstr.ftn Outdated Show resolved Hide resolved
Copy link
Member

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Will merge with develop branch ASAP.

@ukmo-ccbunney
Copy link
Member

Regtests comparison with develop baseline show only one (expected) difference in ww3_uprstrt.out to fix a typo:

2,3c2,3
<                   *** WAVEWATCH III ww3_uprstr Initializing ***
<                  ===============================================
---
>                   *** WAVEWATCH III ww3_uprsrt Initializing ***
>                ===============================================

@ukmo-ccbunney ukmo-ccbunney merged commit 5746cb6 into develop Nov 6, 2019
ukmo-ccbunney pushed a commit that referenced this pull request Jan 14, 2020
Changes including new features and bugfixes for adding WW3 to the GEFSv12 and GFSv16 coupled systems at NCEP:

Added option to write single output (gridded and point) files at individual specified output time steps (NOAA-EMC#141 ), to allow inline post-processing;
Added option to write second stream of restart files (#1 ) with write stride different to first (default) restart file,
Updated ww3_grib for grib2 encoding following recent additions/changes in WMO tables,
Several bugfixes to new output and restart options, including alignment of MPI calls and resources, backwards compatibility with multiple output configurations specified in regtests,
Changes to compile options for WCOSS to allow b4b.
Please find results from the regtest matrix comparisons in the comment below.
@ukmo-ansaulter ukmo-ansaulter deleted the fb_uprstr_seaswell branch April 17, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants