Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename investment phase to stage #288

Merged
merged 5 commits into from
Jul 7, 2017

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Jul 6, 2017

For consistent use of terminology throughout the app.

The investment endpoints still accept and return phase for backwards compatibility.

@reupen reupen requested review from canni and elcct July 6, 2017 16:11
@codecov-io
Copy link

codecov-io commented Jul 6, 2017

Codecov Report

Merging #288 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #288      +/-   ##
===========================================
+ Coverage    92.92%   92.92%   +<.01%     
===========================================
  Files           63       63              
  Lines         2417     2418       +1     
  Branches       212      212              
===========================================
+ Hits          2246     2247       +1     
  Misses         145      145              
  Partials        26       26
Impacted Files Coverage Δ
datahub/investment/views.py 93.42% <ø> (ø) ⬆️
datahub/metadata/views.py 100% <ø> (ø) ⬆️
datahub/search/views.py 98.57% <ø> (ø) ⬆️
datahub/metadata/admin.py 100% <ø> (ø) ⬆️
datahub/search/elasticsearch.py 98.3% <ø> (ø) ⬆️
datahub/investment/serializers.py 99.02% <100%> (ø) ⬆️
datahub/core/constants.py 100% <100%> (ø) ⬆️
datahub/investment/validate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b2b0e...4d38bfd. Read the comment docs.

@reupen reupen merged commit 114bc74 into develop Jul 7, 2017
@reupen reupen deleted the feature/DH-380-investment-phase-rename branch July 7, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants